Add Money.with_bank for Dynamic Currency Stores

[pranavbabu]

This PR introduces the Money.with_bank method, allowing developers to assign different currency stores (banks) dynamically within a scoped block. This is particularly useful for loading custom exchange rates per user session.

Key Changes

• Implemented Money.with_bank(bank_instance), enabling temporary overrides of the default bank.
• Ensures thread safety by restoring the original bank after execution.
• Added documentation and an example demonstrating its usage in a Rails controller with around_action.

[yukideluxe]

@pranavbabu would you mind rebasing your branch with main? We've fixed CI! 😊

[pranavbabu]

@pranavbabu would you mind rebasing your branch with main? We've fixed CI! 😊

Github did merge automatically when I synced my fork ;)

[sunny]

Awesome!

[yukideluxe]

Hello @pranavbabu, thanks for your contribution! I have one question and one concern about this 😊

• Why did you add this change to money-rails instead of to money? I have a feeling this isn’t Rails-specific, so it seems like it might belong in the money gem instead, but I might be missing something, I’m still learning!
• I already had some concerns about this, but after reviewing RubyMoney/money#1128, I’m almost certain this solution won’t be thread-safe. I think it should be implemented similarly to how Money.with_rounding_mode is done using Thread.current. Could you maybe add some tests like the ones here? 🙏🏻

[pranavbabu]

Hey @yukideluxe, I added it to this lib just because we had this fix in our company fork for a very long time , I've never thought about money gem itself since we use rails 😅 so you might be correct and I should address it in another gem, your second point is actually really useful, we had some weird bugs where bank was not set and we had currency exchange problems , so now I know why 🙈 big thanks , I'm gonna close this one in favour of new PR to money gem , after vacation 🤗

[yukideluxe]

Hey @yukideluxe, I added it to this lib just because we had this fix in our company fork for a very long time , I've never thought about money gem itself since we use rails 😅 so you might be correct and I should address it in another gem, your second point is actually really useful, we had some weird bugs where bank was not set and we had currency exchange problems , so now I know why 🙈 big thanks , I'm gonna close this one in favour of new PR to money gem , after vacation 🤗

Great! thanks! I'll keep an eye for your PR in the other repo 👀

[pranavbabu]

Closing in favour of #this PR