Add Money.with_bank for Dynamic Currency Stores#1145
Merged
yukideluxe merged 5 commits intoRubyMoney:mainfrom Jul 23, 2025
Merged
Add Money.with_bank for Dynamic Currency Stores#1145yukideluxe merged 5 commits intoRubyMoney:mainfrom
yukideluxe merged 5 commits intoRubyMoney:mainfrom
Conversation
sunny
approved these changes
Jul 15, 2025
Member
sunny
left a comment
There was a problem hiding this comment.
Much better indeed, love the addition of the spec for thread-safety as well.
Member
|
Can you add a CHANGELOG entry? 🙏🏻 |
pawelma
approved these changes
Jul 15, 2025
Contributor
pawelma
left a comment
There was a problem hiding this comment.
I like the addition, left some comments, mostly nitpicky 😅
yukideluxe
reviewed
Jul 23, 2025
Member
yukideluxe
left a comment
There was a problem hiding this comment.
sorry the delay! thanks for all the changes! this gem uses rbs for typing the method. Would you mind adding that in a similar fashion to
Lines 221 to 234 in 377b0e8
🙏🏻
last thing and I meeeergeeeee
added 2 commits
July 23, 2025 18:00
Contributor
Author
|
@yukideluxe Lets hope I've done it right :D |
yukideluxe
approved these changes
Jul 23, 2025
Member
yukideluxe
left a comment
There was a problem hiding this comment.
looks good to me! thanks! 🙏🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some #discussions with @yukideluxe it seems like this library is a better place for this #PR.
This PR introduces the Money.with_bank method, allowing developers to assign different currency stores (banks) dynamically within a scoped block. This is particularly useful for loading custom exchange rates per user session.
Key Changes