allow using latest version of money gem for development#719
Merged
yukideluxe merged 4 commits intomainfrom Jul 11, 2025
Merged
Conversation
yukideluxe
commented
Jul 11, 2025
| strategy: | ||
| matrix: | ||
| ruby-version: ['3.0', '3.1', '3.2', '3.3', '3.4'] | ||
| ruby-version: ['3.1', '3.2', '3.3', '3.4'] |
Member
Author
There was a problem hiding this comment.
related #717 (comment) and also because the last money requires at least 3.1 ✌🏻
sunny
approved these changes
Jul 11, 2025
Member
sunny
left a comment
sunny
left a comment
There was a problem hiding this comment.
Great use of eval_gemfile, it’ll help reduce duplication!
Guard can be nice… but it is of no use when none of the maintainers use it 😁
Co-authored-by: Sunny Ripert <sunny@sunfox.org>
This was referenced Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I am opening this PR to be able to unblock #698.
The goal is to be able to always develop against the latest version of
moneyGem (or a branch if you wish so) instead of a published version (because that can still take a few days!)I also learned about
eval_gemfiletoday and adjusted the rails gemspecs to avoid duplication inspired but what @sunny suggested here #716 (comment) 😳PS: I removed the Guard* gems, what is that? the
Guardfilerings a bell, but I don't remember ever using that, andguard-rspechasn't been updated in FOREVER so I just 🧹PS2: I haven't forgotten about the mongo tests... 😇