Allow nil to be set as default currency

[sirwolfgang]

This is a part of fixing the #697

[sunny]

Looks good to me! Can you add an entry to the CHANGELOG as well? 🙏🏻

[sirwolfgang]

This is blocked by RubyMoney/money#1095

[yukideluxe]

@sirwolfgang rebase this one with main if you have a chance, please! I just fixed the CI actions 😳

[sirwolfgang]

@yukideluxe Rebased, lmk if I need to make changes to the testing stuff. Seems look right, but it's been a min

[yukideluxe]

@yukideluxe Rebased, lmk if I need to make changes to the testing stuff. Seems look right, but it's been a min

I guess we need to release money first and then change the minimum requirement here https://github.com/RubyMoney/money-rails/blob/main/money-rails.gemspec#L29 to make the tests pass!

We intend to do a release by the end of THIS WEEK, and I'll make sure your change in money gets included 😊 I'll keep ya posted ✌🏻

[yukideluxe]

@sirwolfgang I am back! I did some changes here that I am pretty sure will get this branch green so we can just merge 🙏🏻 Care to resolve the conflicts so we can try?! 😊

[sirwolfgang]

@yukideluxe Done

[tagliala]

Since Money only supports Ruby > 3.1, it is possible to use the safe navigation operator.

This kind of issues can be spotted with RuboCop

Suggested change

	iso_code = default_currency && default_currency.iso_code
	iso_code = default_currency&.iso_code

[tagliala]

it is better to use ensure here in case the test does not pass

[sunny]

Using around like this still calls whatever is called after example.run even when the test fails or raises exceptions, so this is fine 👍🏻

[tagliala]

Thanks, and apologies for the misleading comment.

I have a branch with improvements to the spec, I'll remove the ensure from here

money-rails/spec/active_record/monetizable_spec.rb

Lines 783 to 790 in c7645b0

	around(:each) do |example|
	begin
	Money.locale_backend = :currency
	example.run
	ensure
	Money.locale_backend = :i18n
	end
	end

[yukideluxe]

I am merging this because it has been open for a while! We can work on followup improvements – like https://github.com/RubyMoney/money-rails/pull/698/files#r2202413849 – in another PR 🙏🏻

Thanks <3