Improve specs and add code coverage#1137
Merged
yukideluxe merged 1 commit intoRubyMoney:mainfrom Jul 11, 2025
Merged
Conversation
- Add simplecov for code coverage. Run suite with `COVERAGE=1` - Use the modern configuration settings for `spec_helper.rb` There are failures with the default option `config.shared_context_metadata_behavior = :apply_to_host_groups`. This issue will be fixed separately, ref: RubyMoney#1136
e9b2c37 to
ae62078
Compare
yukideluxe
approved these changes
Jul 11, 2025
Member
yukideluxe
left a comment
There was a problem hiding this comment.
modernizing is always a yes from me ✌🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COVERAGE=1spec_helper.rbThere are failures with the default option
config.shared_context_metadata_behavior = :apply_to_host_groups.This issue will be fixed separately, ref: #1136