Removed requirements for language field #310
Conversation
|
Action JSON Schema / Diff generated schema fails, because the schema in the other repository is not yet updated. Will be fixed soon. Suggest merging after code review anyway. |
There was a problem hiding this comment.
Thanks, @Markus1812. Your changes look good to me. 👍
Action JSON Schema / Diff generated schema fails, because the schema in the other repository is not yet updated. Will be fixed soon. Suggest merging after code review anyway.
Hmm, I think we should try to update the abap-file-fromats repository nearly parallel. Otherwise, as far as I understand, our validation in the abap-file-formats repository will fail and confuse our contributors.
Therefore, I suggest, we prepare the change to update all schemas in the abap-file-formats repository. As soon as this is ready to merge, we merge this and the PR in asap-file-formts repository.
schneidermic0
left a comment
schneidermic0
left a comment
There was a problem hiding this comment.
Looks good to me.
@Markus1812. Welcome as contributor :)
refers to #582