Skip to content

Removed requirements for language field #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schneidermic0 merged 2 commits into from
Apr 10, 2024
+2 −8
Merged

Removed requirements for language field #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a87360c
Removed requirements for language field
Markus1812 Apr 9, 2024
ceeb1e3
Merge branch 'main' into Markus1812/language-tag
albertmink Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/zcl_aff_writer_json_schema.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1043,8 +1043,6 @@ CLASS zcl_aff_writer_json_schema IMPLEMENTATION.

METHOD handle_language_field.
write_tag( `"minLength": 2,` ).
write_tag( `"maxLength": 2,` ).
write_tag( `"pattern": "^[a-z]+$",` ).
ENDMETHOD.


Expand Down
8 changes: 2 additions & 6 deletions src/zcl_aff_writer_json_schema.clas.testclasses.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,9 +610,7 @@ CLASS ltcl_json_writer_abap_doc IMPLEMENTATION.
( ` "title": "Original Language",` )
( ` "description": "Original language of the ABAP object",` )
( ` "type": "string",` )
( ` "minLength": 2,` )
( ` "maxLength": 2,` )
( ` "pattern": "^[a-z]+$"` )
( ` "minLength": 2` )
( ` }` )
( ` },` )
( ` "additionalProperties": false` )
Expand Down Expand Up @@ -1249,9 +1247,7 @@ CLASS ltcl_json_writer_abap_doc IMPLEMENTATION.
( ` "title": "Original Language",` )
( ` "description": "Original language of the ABAP object",` )
( ` "type": "string",` )
( ` "minLength": 2,` )
( ` "maxLength": 2,` )
( ` "pattern": "^[a-z]+$"` )
( ` "minLength": 2` )
( ` },` )
( ` "abapLanguageVersion": {` )
( ` "title": "ABAP Language Version",` )
Expand Down