fix: add Continuum E2Es for B2B My Company #20341

uroslates · 2025-05-20T08:51:48Z

Closes CXSPA-10033

github-actions · 2025-05-21T07:32:10Z

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

cypress · 2025-05-21T07:32:57Z

spartacus Run #49048

Run Properties: Passed #49048 • cc875d52b3 ℹ️: Merge bea9d573bfb61f24aeb62e04eb99c435314ec924 into ab177a9bce64858b4e9f4b0460e5...

Project	`spartacus`
Branch Review	`feature/CXSPA-10033-b2b-mycompany`
Run status	`Passed #49048`
Run duration	`03m 47s`
Commit	`cc875d52b3 ℹ️: Merge bea9d573bfb61f24aeb62e04eb99c435314ec924 into ab177a9bce64858b4e9f4b0460e5...`
Committer	`Uros Lates`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`3`
Pending	`2`
Skipped	`0`
Passing	`99`
View all changes introduced in this branch ↗︎

github-actions · 2025-05-21T07:35:36Z

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

github-actions · 2025-05-21T07:39:20Z

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

github-actions · 2025-05-21T12:09:07Z

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

Pio-Bar

Solid work! My only minor gripe is the use of the overly long selectors. The tests work really well as is but, it makes reading the tests bit confusing.

cy.get('cx-org-unit-details cx-org-card cx-view .main .details .property a[href="/powertools-spa/en/USD/organization/units/Rustic"]' );

Consider replacing with:

cy.get('a').contains(' Rustic ');

Pio-Bar · 2025-05-23T12:22:39Z

...ontapp-e2e-cypress/cypress/e2e/accessibility/b2b.my-company-account-summaries.a11y-e2e.cy.ts

+    it('initial page load', () => {
+      cy.get('main cx-view cx-table table');
+      cy.get('main').a11yRunContinuumTest();
+    });
+
+    it('page loaded', () => {
+      cy.get('#Rustic');
+      cy.get('main').a11yRunContinuumTest();
+    });


Isn't running the scan after the page is fully loaded sufficient? I've seen this repeated in the other files too.

Well in first case its testing skeleton components (where content isn't loaded still) - which in few cases had a11y issues caught by continuum. The second one is validating loaded state (actual table with data).
If this isn't required I can remove the fist one.

Testing the skeleton makes sense I would keep it. Let's replace 'initial page load' with sth that makes it clear that the skeleton is the target. At the same time, we need to make sure the skeleton is actually present for the test. Is there a way we could avoid the possible race condition here?

Pio-Bar · 2025-05-23T12:25:54Z

...ontapp-e2e-cypress/cypress/e2e/accessibility/b2b.my-company-account-summaries.a11y-e2e.cy.ts

+      cy.get('main').a11yRunContinuumTest();
+    });
+
+    it('account summaries details / initial panel', () => {


We should also include a test with the document list populated. The one tested here is empty.

I couldn't find any that has documents. They are all empty.

What about Custom Retail? I definitely see some 😉

Good catch! Thanks. Applied!

Pio-Bar · 2025-05-23T12:28:17Z

...ontapp-e2e-cypress/cypress/e2e/accessibility/b2b.my-company-account-summaries.a11y-e2e.cy.ts

+      cy.get('main').a11yRunContinuumTest();
+    });
+
+    // it('account summaries details / edit panel', () => {


Shouldn't the commented code be cleaned up?

Pio-Bar · 2025-05-23T13:13:52Z

...ects/storefrontapp-e2e-cypress/cypress/e2e/accessibility/b2b.my-company-units.a11y-e2e.cy.ts

+      cy.get('body').a11yRunContinuumTest();
+    });
+
+    it('unit details / delivery addresses list panel', () => {


Some of these cards the tests navigate to are empty. Wouldn't the test be more complete if we go to populated ones instead?

Addressed! 👍

github-actions · 2025-05-26T12:11:31Z

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

Pio-Bar · 2025-05-26T13:33:09Z

...ects/storefrontapp-e2e-cypress/cypress/e2e/accessibility/b2b.my-company-units.a11y-e2e.cy.ts

-        'cx-org-unit-details cx-org-card cx-view .main .details .property a[href="/powertools-spa/en/USD/organization/units/Rustic"]'
-      );
+      cy.get('[id="Rustic"]').click();
+      cy.get('a').contains('Rustic');


I think the text is missing spaces (cy.get('a').contains(' Rustic ')). It's currently getting the wrong element and scanning an empty card.

github-actions · 2025-06-24T11:52:27Z

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

github-actions · 2025-06-26T11:10:15Z

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

github-actions · 2025-07-01T10:22:36Z

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

fix: add b2b mycompany a11y e2e tests

b9e9c0a

uroslates requested a review from a team as a code owner May 20, 2025 08:51

github-actions bot marked this pull request as draft May 20, 2025 08:51

ulates-sap added 2 commits May 20, 2025 12:44

fix: adding more tests

043e112

fix: fix failed unit tests

b7d5f79

uroslates marked this pull request as ready for review May 21, 2025 06:43

Trigger Build

da66ddf

github-actions bot marked this pull request as draft May 21, 2025 07:40

uroslates marked this pull request as ready for review May 21, 2025 11:20

Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany

6095f62

github-actions bot marked this pull request as draft May 22, 2025 11:44

Pio-Bar requested changes May 23, 2025

View reviewed changes

uroslates and others added 2 commits May 26, 2025 11:11

Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany

dd70972

fix: address PR comments

9b93647

uroslates marked this pull request as ready for review May 26, 2025 11:22

uroslates requested a review from Pio-Bar May 26, 2025 11:22

Pio-Bar requested changes May 26, 2025

View reviewed changes

Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany

8142c79

github-actions bot marked this pull request as draft May 27, 2025 08:43

ulates-sap added 3 commits May 27, 2025 11:47

fix: address PR comments - initial skeleton

5032a42

fix: address PR comment

4d8e3a4

fix: address PR comment

a0cdd47

uroslates marked this pull request as ready for review May 27, 2025 10:34

uroslates requested a review from Pio-Bar May 27, 2025 10:34

uroslates marked this pull request as ready for review June 24, 2025 11:31

Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany

23bd9bc

github-actions bot marked this pull request as draft June 26, 2025 10:38

uroslates marked this pull request as ready for review June 26, 2025 10:43

fix: fix faield tests

ebcef7f

github-actions bot marked this pull request as draft June 30, 2025 11:09

Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany

74f28d8

uroslates marked this pull request as ready for review June 30, 2025 11:26

uroslates requested a review from Pio-Bar June 30, 2025 12:03

Pio-Bar previously approved these changes Jul 1, 2025

View reviewed changes

Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany

b232210

github-actions bot marked this pull request as draft July 1, 2025 09:42

uroslates marked this pull request as ready for review July 1, 2025 09:55

fix: fix faield tests

24eff28

uroslates dismissed Pio-Bar’s stale review via 24eff28 July 1, 2025 11:25

github-actions bot marked this pull request as draft July 1, 2025 11:25

uroslates marked this pull request as ready for review July 1, 2025 11:27

uroslates requested a review from Pio-Bar July 1, 2025 11:42

Zeyber approved these changes Jul 2, 2025

View reviewed changes

Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany

da16874

github-actions bot marked this pull request as draft July 2, 2025 07:53

uroslates marked this pull request as ready for review July 2, 2025 07:56

Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany

bea9d57

github-actions bot marked this pull request as draft July 2, 2025 11:34

uroslates marked this pull request as ready for review July 2, 2025 11:38

uroslates merged commit 991ddbe into develop Jul 2, 2025
32 checks passed

uroslates deleted the feature/CXSPA-10033-b2b-mycompany branch July 2, 2025 12:01

fix: add Continuum E2Es for B2B My Company #20341

fix: add Continuum E2Es for B2B My Company #20341

Uh oh!

Conversation

uroslates commented May 20, 2025

Uh oh!

github-actions bot commented May 21, 2025

Merge Checks Failed

Uh oh!

cypress bot commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 21, 2025

Merge Checks Failed

Uh oh!

github-actions bot commented May 21, 2025

Merge Checks Failed

Uh oh!

github-actions bot commented May 21, 2025

Merge Checks Failed

Uh oh!

Pio-Bar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 26, 2025

Merge Checks Failed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 24, 2025

Merge Checks Failed

Uh oh!

github-actions bot commented Jun 26, 2025

Merge Checks Failed

Uh oh!

github-actions bot commented Jul 1, 2025

Merge Checks Failed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cypress bot commented May 21, 2025 •

edited

Loading