Skip to content

fix: add Continuum E2Es for B2B My Company #20341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uroslates merged 32 commits into from
Jul 2, 2025
Merged

fix: add Continuum E2Es for B2B My Company #20341

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
b9e9c0a
fix: add b2b mycompany a11y e2e tests
ulates-sap May 20, 2025
043e112
fix: adding more tests
ulates-sap May 20, 2025
b7d5f79
fix: fix failed unit tests
ulates-sap May 20, 2025
da66ddf
Trigger Build
ulates-sap May 21, 2025
6095f62
Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany
uroslates May 22, 2025
dd70972
Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany
uroslates May 26, 2025
9b93647
fix: address PR comments
ulates-sap May 26, 2025
8142c79
Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany
uroslates May 27, 2025
5032a42
fix: address PR comments - initial skeleton
ulates-sap May 27, 2025
4d8e3a4
fix: address PR comment
ulates-sap May 27, 2025
a0cdd47
fix: address PR comment
ulates-sap May 27, 2025
1efe0af
fix: address PR comments
ulates-sap May 28, 2025
c5d3da2
Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany
uroslates May 28, 2025
0da8fe1
Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany
uroslates May 28, 2025
3586bcf
Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany
uroslates Jun 2, 2025
63dfe6c
fix: address PR comments
ulates-sap Jun 2, 2025
2c19682
Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany
uroslates Jun 3, 2025
0ef5b51
Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany
uroslates Jun 4, 2025
ba0bbdb
Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany
uroslates Jun 5, 2025
f5aef90
Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany
uroslates Jun 6, 2025
23567ae
Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany
uroslates Jun 23, 2025
961cfa1
fix: fix purchase-limits test
ulates-sap Jun 23, 2025
9c3d9ba
Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany
uroslates Jun 24, 2025
d6ce479
fix: remove problematic test and move files to new location
ulates-sap Jun 24, 2025
c876c17
Trigger Build
ulates-sap Jun 24, 2025
23bd9bc
Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany
uroslates Jun 26, 2025
ebcef7f
fix: fix faield tests
ulates-sap Jun 30, 2025
74f28d8
Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany
uroslates Jun 30, 2025
b232210
Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany
uroslates Jul 1, 2025
24eff28
fix: fix faield tests
ulates-sap Jul 1, 2025
da16874
Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany
uroslates Jul 2, 2025
bea9d57
Merge branch 'develop' into feature/CXSPA-10033-b2b-mycompany
uroslates Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 0 additions & 143 deletions ...app-e2e-cypress/cypress/e2e/accessibility/b2b.my-company-account-summaries.a11y-e2e.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,148 +38,5 @@ describe(
);
cy.get('main').a11yRunContinuumTest();
});

// it('account summaries details / edit panel', () => {
// cy.get(
// 'cx-org-unit-details cx-org-card cx-view .header .actions .btn.edit'
// ).click();
// cy.get('cx-org-unit-details cx-org-card cx-view .main .details input');
// cy.get('cx-org-unit-details').a11yRunContinuumTest();
// });

// it('unit details / edit-save panel', () => {
// cy.get(
// 'cx-org-unit-details cx-org-card cx-view .header .actions .btn.btn-primary'
// ).click();
// cy.get(
// 'cx-org-unit-details cx-org-card cx-view .main cx-org-notification'
// );
// cy.get(
// 'cx-org-unit-details cx-org-card cx-view .main .details .property a[href="/powertools-spa/en/USD/organization/units/Rustic"]'
// );
// cy.get('cx-org-unit-details').a11yRunContinuumTest();
// });

// it('unit details / links list / child units panel', () => {
// cy.get(
// 'cx-org-unit-details .main .link-list a.link:nth-child(1)'
// ).click();
// cy.get(
// 'cx-org-unit-children cx-org-sub-list cx-org-card cx-view .main cx-table table cx-org-unit-details-cell button'
// );
// cy.get(
// 'cx-org-unit-children cx-org-sub-list cx-org-card cx-view .main cx-table table tr:nth-child(2) cx-org-unit-details-cell button'
// ).click();
// cy.get('cx-org-unit-details').a11yRunContinuumTest();
// });

// it('unit details / links list / child units / create panel', () => {
// cy.get(
// 'cx-org-unit-details cx-org-unit-children .header .actions .btn'
// ).click();
// cy.get('cx-org-unit-details cx-org-unit-children .main input');
// cy.get('cx-org-unit-details').a11yRunContinuumTest();
// });

// it('unit details / users list panel', () => {
// // TODO: save as rusticServicesBreadcrumb and reuse elsewhere!
// cy.get(
// 'cx-breadcrumb a[href="/powertools-spa/en/USD/organization/units/Rustic%20Services"]'
// ).click();
// cy.get(
// 'cx-org-unit-details .main .link-list a.link:nth-child(2)'
// ).click();
// cy.get(
// 'cx-org-unit-details .main cx-table table tr:nth-child(2) td.roles a'
// );
// cy.get(
// 'cx-org-unit-details .main cx-table table tr:nth-child(2) button'
// ).click();
// cy.get('cx-org-unit-details').a11yRunContinuumTest();
// });

// it('unit details / users list / roles and rights panel', () => {
// cy.get(
// 'cx-org-unit-details .main cx-table table tr:nth-child(2) td.roles a'
// ).click();
// cy.get('cx-org-unit-user-roles form input');
// cy.get('cx-org-unit-details').a11yRunContinuumTest();
// });

// it('unit details / approvers list panel', () => {
// // TODO: save as rusticServicesBreadcrumb and reuse elsewhere!
// cy.get(
// 'cx-breadcrumb a[href="/powertools-spa/en/USD/organization/units/Rustic%20Services"]'
// ).click();
// cy.get(
// 'cx-org-unit-details .main .link-list a.link:nth-child(3)'
// ).click();
// cy.get(
// 'cx-org-unit-assigned-approver-list cx-org-sub-list .main .is-empty'
// );
// cy.get('cx-org-unit-assigned-approver-list').a11yRunContinuumTest();
// });

// it('unit details / approvers list / manage approvers panel', () => {
// cy.get(
// 'cx-org-unit-assigned-approver-list cx-org-sub-list .header .btn:first-child'
// ).click();
// cy.get(
// 'cx-org-unit-approver-list cx-org-sub-list cx-table table tr:nth-child(2) td.orgUnit span[title="Services East"]'
// );
// cy.get(
// 'cx-org-unit-approver-list cx-org-sub-list cx-table table tr:nth-child(2) cx-org-user-details-cell button'
// ).click();
// cy.get('cx-org-unit-approver-list').a11yRunContinuumTest();
// });

// it('unit details / approvers list / manage approvers assign panel', () => {
// // Assign button click
// cy.get(
// 'cx-org-unit-approver-list cx-org-sub-list cx-table table tr:nth-child(2) cx-org-assign-cell button'
// ).click();
// cy.get('cx-global-message .alert-danger');
// cy.get('body').a11yRunContinuumTest();
// });

// it('unit details / delivery addresses list panel', () => {
// // TODO: save as rusticServicesBreadcrumb and reuse elsewhere!
// cy.get(
// 'cx-breadcrumb a[href="/powertools-spa/en/USD/organization/units/Rustic%20Services"]'
// ).click();
// cy.get(
// 'cx-org-unit-details .main .link-list a.link:nth-child(4)'
// ).click();
// cy.get('cx-org-unit-address-list cx-org-sub-list .main .is-empty');
// cy.get('cx-org-unit-address-list').a11yRunContinuumTest();
// });

// it('unit details / delivery addresses list / create panel', () => {
// cy.get(
// 'cx-org-unit-address-list cx-org-sub-list .header .btn:first-child'
// ).click();
// cy.get('cx-org-unit-address-list cx-org-sub-list input');
// cy.get('cx-org-unit-address-list').a11yRunContinuumTest();
// });

// it('unit details / const centers list panel', () => {
// // TODO: save as rusticServicesBreadcrumb and reuse elsewhere!
// cy.get(
// 'cx-breadcrumb a[href="/powertools-spa/en/USD/organization/units/Rustic%20Services"]'
// ).click();
// cy.get(
// 'cx-org-unit-details .main .link-list a.link:nth-child(5)'
// ).click();
// cy.get('cx-org-unit-cost-centers cx-org-sub-list .main .is-empty');
// cy.get('cx-org-unit-cost-centers').a11yRunContinuumTest();
// });

// it('unit details / const centers list / create panel', () => {
// cy.get(
// 'cx-org-unit-cost-centers cx-org-sub-list .header .btn:first-child'
// ).click();
// cy.get('cx-org-unit-cost-centers cx-org-sub-list input');
// cy.get('cx-org-unit-cost-centers').a11yRunContinuumTest();
// });
}
);
46 changes: 16 additions & 30 deletions ...s/storefrontapp-e2e-cypress/cypress/e2e/accessibility/b2b.my-company-units.a11y-e2e.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,8 @@ describe(
});

it('unit details / initial panel', () => {
cy.get('[id="Rustic Services"]').click();
cy.get(
'cx-org-unit-details cx-org-card cx-view .main .details .property a[href="/powertools-spa/en/USD/organization/units/Rustic"]'
);
cy.get('[id="Rustic"]').click();
cy.get('a').contains('Rustic');
Copy link
Contributor

@Pio-Bar Pio-Bar May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the text is missing spaces (cy.get('a').contains(' Rustic ')). It's currently getting the wrong element and scanning an empty card.
image

Copy link
Contributor Author

@uroslates uroslates May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied!

Copy link
Contributor

@Pio-Bar Pio-Bar May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cy.get('a').contains('Rustic');

Isn't this just dead code after the change?

Copy link
Contributor Author

@uroslates uroslates May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed!

cy.get('cx-org-unit-details').a11yRunContinuumTest();
});

Expand All @@ -54,9 +52,7 @@ describe(
cy.get(
'cx-org-unit-details cx-org-card cx-view .main cx-org-notification'
);
cy.get(
'cx-org-unit-details cx-org-card cx-view .main .details .property a[href="/powertools-spa/en/USD/organization/units/Rustic"]'
);
cy.get('a').contains('Rustic');
Copy link
Contributor

@Pio-Bar Pio-Bar May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't a wrong element grabbed here as well?

Copy link
Contributor Author

@uroslates uroslates May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed!

cy.get('cx-org-unit-details').a11yRunContinuumTest();
});

Expand All @@ -82,9 +78,8 @@ describe(
});

it('unit details / users list panel', () => {
// TODO: save as rusticServicesBreadcrumb and reuse elsewhere!
cy.get(
'cx-breadcrumb a[href="/powertools-spa/en/USD/organization/units/Rustic%20Services"]'
'cx-breadcrumb a[href="/powertools-spa/en/USD/organization/units/Rustic"]'
).click();
cy.get(
'cx-org-unit-details .main .link-list a.link:nth-child(2)'
Expand All @@ -107,50 +102,42 @@ describe(
});

it('unit details / approvers list panel', () => {
// TODO: save as rusticServicesBreadcrumb and reuse elsewhere!
cy.get(
'cx-breadcrumb a[href="/powertools-spa/en/USD/organization/units/Rustic%20Services"]'
'cx-breadcrumb a[href="/powertools-spa/en/USD/organization/units/Rustic"]'
).click();
cy.get(
'cx-org-unit-details .main .link-list a.link:nth-child(3)'
).click();
cy.get(
'cx-org-unit-assigned-approver-list cx-org-sub-list .main .is-empty'
);
cy.get('td.actions button');
cy.get('cx-org-unit-assigned-approver-list').a11yRunContinuumTest();
});

it('unit details / approvers list / manage approvers panel', () => {
cy.get(
'cx-org-unit-assigned-approver-list cx-org-sub-list .header .btn:first-child'
).click();
cy.get(
'cx-org-unit-approver-list cx-org-sub-list cx-table table tr:nth-child(2) td.orgUnit span[title="Services East"]'
);
cy.get(
'cx-org-unit-approver-list cx-org-sub-list cx-table table tr:nth-child(2) cx-org-user-details-cell button'
).click();
cy.get('.actions cx-org-assign-cell button');
cy.get('table tr:nth-child(2) cx-org-user-details-cell button').click();
cy.get('cx-org-unit-approver-list').a11yRunContinuumTest();
});

it('unit details / approvers list / manage approvers assign panel', () => {
// Assign button click
cy.get(
'cx-org-unit-approver-list cx-org-sub-list cx-table table tr:nth-child(2) cx-org-assign-cell button'
'table tr:nth-child(2) .actions cx-org-assign-cell button'
).click();
cy.get('cx-global-message .alert-danger');
cy.get('.main cx-org-message cx-org-notification');
cy.get('body').a11yRunContinuumTest();
});

it('unit details / delivery addresses list panel', () => {
Copy link
Contributor

@Pio-Bar Pio-Bar May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these cards the tests navigate to are empty. Wouldn't the test be more complete if we go to populated ones instead?

image

Copy link
Contributor Author

@uroslates uroslates May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed! 👍

// TODO: save as rusticServicesBreadcrumb and reuse elsewhere!
cy.get(
'cx-breadcrumb a[href="/powertools-spa/en/USD/organization/units/Rustic%20Services"]'
'cx-breadcrumb a[href="/powertools-spa/en/USD/organization/units/Rustic"]'
).click();
cy.get(
'cx-org-unit-details .main .link-list a.link:nth-child(4)'
).click();
cy.get('cx-org-unit-address-list cx-org-sub-list .main .is-empty');
cy.get('td.formattedAddress cx-org-link-cell a');
cy.get('cx-org-unit-address-list').a11yRunContinuumTest();
});

Expand All @@ -162,19 +149,18 @@ describe(
cy.get('cx-org-unit-address-list').a11yRunContinuumTest();
});

it('unit details / const centers list panel', () => {
// TODO: save as rusticServicesBreadcrumb and reuse elsewhere!
it('unit details / cost centers list panel', () => {
cy.get(
'cx-breadcrumb a[href="/powertools-spa/en/USD/organization/units/Rustic%20Services"]'
'cx-breadcrumb a[href="/powertools-spa/en/USD/organization/units/Rustic"]'
).click();
cy.get(
'cx-org-unit-details .main .link-list a.link:nth-child(5)'
).click();
cy.get('cx-org-unit-cost-centers cx-org-sub-list .main .is-empty');
cy.get('cx-org-cost-center-details-cell button');
cy.get('cx-org-unit-cost-centers').a11yRunContinuumTest();
});

it('unit details / const centers list / create panel', () => {
it('unit details / cost centers list / create panel', () => {
cy.get(
'cx-org-unit-cost-centers cx-org-sub-list .header .btn:first-child'
).click();
Expand Down
Loading