Skip to content

Hide artwork in landscape and make the whole controller scrollable #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MGaetan89
Copy link
Member

Description

This PR updates the layout of the controller dialog to be more usable in landscape.

Changes made

  • Make the controller scrollable.
  • Hide the artwork image in the controller in landscape.
  • Move MediaRouteSelector to the ViewModel in the demo app.
  • Add screenshot tests in landscape.

@MGaetan89 MGaetan89 self-assigned this May 6, 2025
@MGaetan89 MGaetan89 linked an issue May 6, 2025 that may be closed by this pull request
1 task
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox May 6, 2025
Copy link

github-actions bot commented May 6, 2025

Code Coverage

Overall Project 38.6% -0.62% 🟢
Files changed 12.5% 🟢

File Coverage
MediaRouteControllerDialogViewModel.kt 78.86% 🟢
MediaRouteControllerDialog.kt 0% -3.26% 🟢

@MGaetan89 MGaetan89 marked this pull request as ready for review May 6, 2025 13:45
@MGaetan89 MGaetan89 requested a review from StaehliJ May 6, 2025 13:55
@MGaetan89 MGaetan89 force-pushed the 83-fix-layout-when-the-space-is-limited branch from 99e336a to 1ea1025 Compare May 7, 2025 07:38
@MGaetan89 MGaetan89 force-pushed the 83-fix-layout-when-the-space-is-limited branch from 1ea1025 to cee937e Compare May 8, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

Successfully merging this pull request may close these issues.

Fix layout when the space is limited
1 participant