Skip to content

fix(reviewer-bot): harden GitHub API failure handling #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PLeVasseur wants to merge 209 commits into from
Closed

fix(reviewer-bot): harden GitHub API failure handling #546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
209 commits
Select commit Hold shift + click to select a range
aaa94eb
fix(reviewer-bot): harden GitHub API failure handling
PLeVasseur Mar 30, 2026
7791d4a
fix(reviewer-bot): harden persistence and projection contracts
PLeVasseur Mar 31, 2026
ba4b842
test(reviewer-bot): split reviewer bot test suite
PLeVasseur Mar 31, 2026
b1651e5
test(reviewer-bot): preserve comment routing coverage parity
PLeVasseur Mar 31, 2026
859dc53
ci(reviewer-bot): watch reviewer bot library changes
PLeVasseur Mar 31, 2026
dd2d757
test(reviewer-bot): add importlib-ready test support tree
PLeVasseur Mar 31, 2026
d7284bd
ci(reviewer-bot): enforce targeted coverage floors
PLeVasseur Mar 31, 2026
b32969d
test(reviewer-bot): mirror github api tests under tests
PLeVasseur Mar 31, 2026
5623adb
test(reviewer-bot): mirror state store and adapter tests
PLeVasseur Mar 31, 2026
aa1a804
ci(reviewer-bot): run migrated tests in parallel
PLeVasseur Mar 31, 2026
2a0f88d
test(reviewer-bot): mirror lease lock tests under tests
PLeVasseur Mar 31, 2026
6de6859
test(reviewer-bot): mirror overdue tests under tests
PLeVasseur Mar 31, 2026
c232767
test(reviewer-bot): mirror maintenance tests under tests
PLeVasseur Mar 31, 2026
7708835
test(reviewer-bot): extract workflow contract checks
PLeVasseur Mar 31, 2026
a5117f7
test(reviewer-bot): extract artifact contract checks
PLeVasseur Mar 31, 2026
1f7fc94
test(reviewer-bot): expand workflow file contracts
PLeVasseur Mar 31, 2026
260f4dd
refactor(reviewer-bot): introduce thin runtime object
PLeVasseur Mar 31, 2026
c3ca129
refactor(reviewer-bot): add explicit app event context
PLeVasseur Mar 31, 2026
2fcf272
test(reviewer-bot): extract app event intent tests
PLeVasseur Mar 31, 2026
bcd7dc3
test(reviewer-bot): extract app workflow path tests
PLeVasseur Mar 31, 2026
51d2b85
test(reviewer-bot): extract app execution tests
PLeVasseur Mar 31, 2026
38ad2a0
test(reviewer-bot): extract workflow bookkeeping tests
PLeVasseur Mar 31, 2026
d761e89
test(reviewer-bot): extract reviewer board preview tests
PLeVasseur Mar 31, 2026
362c3df
test(reviewer-bot): extract app schedule repair tests
PLeVasseur Mar 31, 2026
0e36f43
test(reviewer-bot): extract closed issue cleanup tests
PLeVasseur Mar 31, 2026
0eced77
test(reviewer-bot): extract schedule bookkeeping tests
PLeVasseur Mar 31, 2026
439a567
test(reviewer-bot): extract state unavailable tests
PLeVasseur Mar 31, 2026
a65a255
refactor(reviewer-bot): extract reviews projection helpers
PLeVasseur Mar 31, 2026
062db96
test(reviewer-bot): extract reviews api contract tests
PLeVasseur Mar 31, 2026
0b1b994
test(reviewer-bot): extract reviews live fetch tests
PLeVasseur Mar 31, 2026
4b00e44
test(reviewer-bot): expand reviews live fetch tests
PLeVasseur Apr 1, 2026
ed8c2b3
refactor(reviewer-bot): mark canonical reviews entrypoints
PLeVasseur Apr 1, 2026
63028e8
refactor(reviewer-bot): isolate reviews live read helpers
PLeVasseur Apr 1, 2026
20a05f5
refactor(reviewer-bot): split reviews normalization helpers
PLeVasseur Apr 1, 2026
b7be34d
refactor(reviewer-bot): add typed deferred reconcile payloads
PLeVasseur Apr 1, 2026
464ed8f
refactor(reviewer-bot): add typed comment replay context
PLeVasseur Apr 1, 2026
d93c222
refactor(reviewer-bot): add typed review replay context
PLeVasseur Apr 1, 2026
0d92057
test(reviewer-bot): extract reconcile workflow run tests
PLeVasseur Apr 1, 2026
bdc33b9
test(reviewer-bot): expand reconcile workflow run tests
PLeVasseur Apr 1, 2026
3a67f3b
test(reviewer-bot): expand reconcile replay coverage
PLeVasseur Apr 1, 2026
c6f57e4
test(reviewer-bot): expand reconcile comment replay tests
PLeVasseur Apr 1, 2026
644a9d2
test(reviewer-bot): expand reconcile fail closed coverage
PLeVasseur Apr 1, 2026
a311976
test(reviewer-bot): extract reconcile privileged command tests
PLeVasseur Apr 1, 2026
b532099
test(reviewer-bot): move sweeper keyed gap tests
PLeVasseur Apr 1, 2026
956d401
test(reviewer-bot): move reconcile helper tests
PLeVasseur Apr 1, 2026
24022a3
test(reviewer-bot): move reconcile artifact tests
PLeVasseur Apr 1, 2026
59d1031
test(reviewer-bot): move reconcile replay tests
PLeVasseur Apr 1, 2026
0ef52a4
test(reviewer-bot): move remaining sweeper reconcile tests
PLeVasseur Apr 1, 2026
2dee442
test(reviewer-bot): retire legacy reconcile file
PLeVasseur Apr 1, 2026
6a204ca
test(reviewer-bot): move additional sweeper logic tests
PLeVasseur Apr 1, 2026
6460a6b
test(reviewer-bot): split sweeper download tests
PLeVasseur Apr 1, 2026
8d96d63
fix(reviewer-bot): stop stale replay from resetting reminders
PLeVasseur Apr 1, 2026
6771bbb
test(reviewer-bot): retire legacy sweeper file
PLeVasseur Apr 1, 2026
ca2d189
test(reviewer-bot): retire legacy comment routing file
PLeVasseur Apr 1, 2026
1830a71
test(reviewer-bot): retire legacy commands file
PLeVasseur Apr 1, 2026
54d7511
test(reviewer-bot): retire legacy project board file
PLeVasseur Apr 1, 2026
0f0c6f5
test(reviewer-bot): retire legacy lifecycle file
PLeVasseur Apr 1, 2026
a618041
ci(reviewer-bot): make migrated tests authoritative
PLeVasseur Apr 1, 2026
2786270
test(reviewer-bot): retire legacy reviewer bot tree
PLeVasseur Apr 1, 2026
ab60102
ci(reviewer-bot): store coverage artifacts under artifacts
PLeVasseur Apr 1, 2026
315ceeb
ci(reviewer-bot): finalize migrated test configuration
PLeVasseur Apr 1, 2026
8608641
ci(reviewer-bot): add marker-based test jobs
PLeVasseur Apr 1, 2026
e72805b
refactor(reviewer-bot): type comment routing requests
PLeVasseur Apr 1, 2026
42aa41c
refactor(reviewer-bot): type command request inputs
PLeVasseur Apr 1, 2026
f64b8b5
refactor(reviewer-bot): harden runtime service seams
PLeVasseur Apr 1, 2026
cc8f85b
test(reviewer-bot): add review scenario builders
PLeVasseur Apr 2, 2026
ba09bdf
test(reviewer-bot): add a shared GitHub transport fake
PLeVasseur Apr 2, 2026
d951df5
test(reviewer-bot): add a reconcile replay harness
PLeVasseur Apr 2, 2026
28f5beb
test(reviewer-bot): add an app CLI harness
PLeVasseur Apr 2, 2026
4be607a
test(reviewer-bot): add a commands harness
PLeVasseur Apr 2, 2026
51d9954
test(reviewer-bot): add a comment routing harness
PLeVasseur Apr 2, 2026
c45ea07
test(reviewer-bot): streamline review state scenarios
PLeVasseur Apr 2, 2026
36ff400
test(reviewer-bot): contract the shared GitHub transport fake
PLeVasseur Apr 2, 2026
37884dc
test(reviewer-bot): add sweeper scenario builders
PLeVasseur Apr 2, 2026
07c28b3
test(reviewer-bot): add a shared app fake runtime
PLeVasseur Apr 2, 2026
bbc33fa
test(reviewer-bot): share fake runtime across harnesses
PLeVasseur Apr 2, 2026
11f6cf4
test(reviewer-bot): contract the shared fake runtime
PLeVasseur Apr 2, 2026
5aa7b81
refactor(reviewer-bot): require typed comment routing inputs
PLeVasseur Apr 2, 2026
cc85430
refactor(reviewer-bot): unify command automation seams
PLeVasseur Apr 2, 2026
6a74cd3
refactor(reviewer-bot): narrow app runtime protocols
PLeVasseur Apr 2, 2026
5a93222
refactor(reviewer-bot): type reconcile comment replay
PLeVasseur Apr 2, 2026
7ee557b
test(reviewer-bot): canonicalize fake runtime usage
PLeVasseur Apr 2, 2026
1be3ae8
test(reviewer-bot): centralize fixture env and recorder helpers
PLeVasseur Apr 2, 2026
11b404a
test(reviewer-bot): initialize fake runtime lease context
PLeVasseur Apr 2, 2026
6b6367e
refactor(reviewer-bot): centralize env request builders
PLeVasseur Apr 2, 2026
0c494a4
refactor(reviewer-bot): extract comment application service
PLeVasseur Apr 2, 2026
46ffd5e
refactor(reviewer-bot): extract public review state surface
PLeVasseur Apr 2, 2026
023e2b0
refactor(reviewer-bot): route comment application through review state
PLeVasseur Apr 2, 2026
98112b7
refactor(reviewer-bot): compose runtime from explicit services
PLeVasseur Apr 2, 2026
3c90d45
test(reviewer-bot): stabilize app runtime test seams
PLeVasseur Apr 2, 2026
244d5ab
test(reviewer-bot): finish app workflow bookkeeping stabilization
PLeVasseur Apr 2, 2026
0cf3eaa
test(reviewer-bot): collapse shared helper imports
PLeVasseur Apr 3, 2026
a2a4b9b
test(reviewer-bot): move pure library tests off shim
PLeVasseur Apr 3, 2026
01492d7
test(reviewer-bot): move harnessed tests off shim
PLeVasseur Apr 3, 2026
6642ae1
test(reviewer-bot): move more unit tests off shim
PLeVasseur Apr 3, 2026
6151b32
test(reviewer-bot): move reconcile unit tests off shim
PLeVasseur Apr 3, 2026
93ba0a4
test(reviewer-bot): move reconcile unit tests off shim
PLeVasseur Apr 3, 2026
45936d4
test(reviewer-bot): move more review tests off shim
PLeVasseur Apr 3, 2026
9c5b972
test(reviewer-bot): move review projection tests off shim
PLeVasseur Apr 3, 2026
a513ff3
test(reviewer-bot): move lifecycle cluster off shim
PLeVasseur Apr 3, 2026
517d134
test(reviewer-bot): move sweeper tests off shim
PLeVasseur Apr 3, 2026
730c8ab
refactor(reviewer-bot): complete import-boundary collapse
PLeVasseur Apr 3, 2026
b67295f
test(reviewer-bot): harden authority contracts
PLeVasseur Apr 3, 2026
85eae87
test(reviewer-bot): cut over transport fake imports
PLeVasseur Apr 3, 2026
2a2ff06
test(reviewer-bot): isolate low-level HTTP fixtures
PLeVasseur Apr 3, 2026
75d851c
refactor(reviewer-bot): tighten fake runtime shape
PLeVasseur Apr 3, 2026
d75c1a3
test(reviewer-bot): add shared typed request builders
PLeVasseur Apr 3, 2026
aed6b7c
refactor(reviewer-bot): make command tests typed-first
PLeVasseur Apr 3, 2026
0c05a83
refactor(reviewer-bot): make replay tests typed-first
PLeVasseur Apr 3, 2026
79310f7
refactor(reviewer-bot): narrow mutable review-state ownership
PLeVasseur Apr 3, 2026
8726e79
refactor(reviewer-bot): close review-state ownership gaps
PLeVasseur Apr 3, 2026
364d5bd
refactor(reviewer-bot): remove privileged command env hydration
PLeVasseur Apr 3, 2026
99d41d1
refactor(reviewer-bot): centralize lifecycle event decoding
PLeVasseur Apr 3, 2026
81b0707
refactor(reviewer-bot): type lifecycle event inputs
PLeVasseur Apr 3, 2026
a23ddb3
refactor(reviewer-bot): clarify reconcile replay scenarios
PLeVasseur Apr 3, 2026
299955d
refactor(reviewer-bot): polish reconcile workflow tests
PLeVasseur Apr 3, 2026
c747a60
refactor(reviewer-bot): add narrow protocol foundations
PLeVasseur Apr 3, 2026
6151599
test(reviewer-bot): separate runtime protocol compatibility checks
PLeVasseur Apr 3, 2026
1c78800
refactor(reviewer-bot): route event input builders through runtime co…
PLeVasseur Apr 3, 2026
700d0b1
refactor(reviewer-bot): use typed request builders in harnesses
PLeVasseur Apr 3, 2026
f075a98
refactor(reviewer-bot): remove ambient env reads from event handlers
PLeVasseur Apr 4, 2026
7060f1a
refactor(reviewer-bot): read reviewer board settings from runtime config
PLeVasseur Apr 4, 2026
c01d279
refactor(reviewer-bot): add typed runtime config accessors
PLeVasseur Apr 4, 2026
b87e102
refactor(reviewer-bot): add injectable runtime infra services
PLeVasseur Apr 4, 2026
1cd08fe
test(reviewer-bot): add deterministic infra fakes
PLeVasseur Apr 4, 2026
0a82b94
refactor(reviewer-bot): inject time and logging into state store
PLeVasseur Apr 4, 2026
4793774
refactor(reviewer-bot): inject time and identity services into lease …
PLeVasseur Apr 4, 2026
7130ce4
refactor(reviewer-bot): inject rest transport into github api helpers
PLeVasseur Apr 4, 2026
32ae81d
refactor(reviewer-bot): inject graphql transport into github api helpers
PLeVasseur Apr 4, 2026
2104296
refactor(reviewer-bot): add shared retry policy primitives
PLeVasseur Apr 4, 2026
3eb241a
refactor(reviewer-bot): share rest retry policy logic
PLeVasseur Apr 4, 2026
a983503
refactor(reviewer-bot): share graphql retry policy logic
PLeVasseur Apr 4, 2026
d694521
refactor(reviewer-bot): share retry helpers in state store workflows
PLeVasseur Apr 4, 2026
fc29325
refactor(reviewer-bot): share retry helpers in lease lock workflows
PLeVasseur Apr 4, 2026
241aeb6
refactor(reviewer-bot): route command defaults through runtime-backed…
PLeVasseur Apr 4, 2026
937a652
refactor(reviewer-bot): preserve command parser behavior while narrow…
PLeVasseur Apr 4, 2026
b1d7254
refactor(reviewer-bot): remove ambient env builders from comment routing
PLeVasseur Apr 4, 2026
d57c7d8
refactor(reviewer-bot): use structured logging in comment routing
PLeVasseur Apr 4, 2026
cc5560b
refactor(reviewer-bot): stabilize reconcile transport seams
PLeVasseur Apr 4, 2026
78b734b
refactor(reviewer-bot): inject time and logging into reconcile
PLeVasseur Apr 4, 2026
9e4f2bd
refactor(reviewer-bot): inject artifact download transport into sweeper
PLeVasseur Apr 4, 2026
571fd80
refactor(reviewer-bot): share retry helpers in sweeper downloads
PLeVasseur Apr 4, 2026
98510c2
refactor(reviewer-bot): read sweeper settings from runtime config
PLeVasseur Apr 4, 2026
0229697
refactor(reviewer-bot): add structured logging interfaces
PLeVasseur Apr 4, 2026
9889640
refactor(reviewer-bot): use structured logging in github api helpers
PLeVasseur Apr 4, 2026
ef11f92
refactor(reviewer-bot): use structured logging in state and lock serv…
PLeVasseur Apr 4, 2026
e3cbe5a
refactor(reviewer-bot): use structured logging in orchestration paths
PLeVasseur Apr 4, 2026
fcb0f9a
refactor(reviewer-bot): narrow leaf module protocol dependencies
PLeVasseur Apr 4, 2026
da62258
refactor(reviewer-bot): narrow core module protocol dependencies
PLeVasseur Apr 4, 2026
f686f19
refactor(reviewer-bot): compose runtime from explicit services
PLeVasseur Apr 4, 2026
9bc2d1f
refactor(reviewer-bot): make bootstrap config services explicit
PLeVasseur Apr 4, 2026
3b61a13
refactor(reviewer-bot): make bootstrap transport and state wiring exp…
PLeVasseur Apr 4, 2026
dbae7fd
refactor(reviewer-bot): make bootstrap handler wiring explicit
PLeVasseur Apr 4, 2026
faaa2f6
test(reviewer-bot): add focused fake services
PLeVasseur Apr 4, 2026
832da80
test(reviewer-bot): rebalance support-layer ownership contracts
PLeVasseur Apr 4, 2026
fd77579
test(reviewer-bot): compose app harness from focused fakes
PLeVasseur Apr 4, 2026
63ee66d
test(reviewer-bot): narrow command comment and reconcile harnesses
PLeVasseur Apr 4, 2026
9502290
test(reviewer-bot): shrink fake runtime to compatibility shell
PLeVasseur Apr 4, 2026
fb4f33a
test(reviewer-bot): remove module patching from github api tests
PLeVasseur Apr 4, 2026
a42e20e
test(reviewer-bot): remove module patching from lease lock tests
PLeVasseur Apr 4, 2026
c67ce4e
test(reviewer-bot): use focused fakes in board and sweeper tests
PLeVasseur Apr 4, 2026
9039441
refactor(reviewer-bot): add explicit runtime factory entrypoint
PLeVasseur Apr 4, 2026
972038b
test(reviewer-bot): use runtime factories in integration paths
PLeVasseur Apr 4, 2026
d831531
refactor(reviewer-bot): remove global runtime singleton
PLeVasseur Apr 4, 2026
b8c4422
test(reviewer-bot): align validation fixes with explicit runtime flow
PLeVasseur Apr 4, 2026
f5fe01e
test(reviewer-bot): add sequenced shared transport fake behavior
PLeVasseur Apr 4, 2026
fb9e7d4
test(reviewer-bot): standardize github api tests on shared transport …
PLeVasseur Apr 4, 2026
bdf4779
test(reviewer-bot): standardize sweeper download tests on focused tra…
PLeVasseur Apr 4, 2026
c96f772
refactor(reviewer-bot): remove ambient env reads from github api assi…
PLeVasseur Apr 4, 2026
a1a5401
refactor(reviewer-bot): make runtime accessors the primary config aut…
PLeVasseur Apr 4, 2026
83e36dd
refactor(reviewer-bot): require structured logger in core library mod…
PLeVasseur Apr 4, 2026
ce07d25
refactor(reviewer-bot): replace remaining internal prints in command …
PLeVasseur Apr 4, 2026
bbac210
refactor(reviewer-bot): separate cli output from internal maintenance…
PLeVasseur Apr 4, 2026
9ee0ba6
refactor(reviewer-bot): replace bootstrap adapter namespace with expl…
PLeVasseur Apr 4, 2026
6b4607e
refactor(reviewer-bot): further shrink runtime delegation surface
PLeVasseur Apr 4, 2026
f924394
test(reviewer-bot): reduce fake runtime to mostly delegated compatibi…
PLeVasseur Apr 4, 2026
3a7aa91
test(reviewer-bot): remove runtime factory patching from app harness
PLeVasseur Apr 4, 2026
8f91b1d
test(reviewer-bot): remove final sleep patch from github api tests
PLeVasseur Apr 4, 2026
7f32954
test(reviewer-bot): reduce ad hoc runtime shells in state and mainten…
PLeVasseur Apr 4, 2026
7c2b4f8
refactor(reviewer-bot): inject transport and logging into members helper
PLeVasseur Apr 4, 2026
e812608
test(reviewer-bot): support direct-url focused transport stubs
PLeVasseur Apr 4, 2026
ce7f894
test(reviewer-bot): align bookkeeping tests with explicit runtime flow
PLeVasseur Apr 4, 2026
5dc4e13
test(reviewer-bot): realign architecture contracts with authority bou…
PLeVasseur Apr 4, 2026
c6fcb64
refactor(reviewer-bot): retire broad runtime delegation surface
PLeVasseur Apr 4, 2026
3c03b3d
refactor(reviewer-bot): align command flows with slimmer runtime surface
PLeVasseur Apr 4, 2026
72e6dc5
refactor(reviewer-bot): split bootstrap adapter wiring by responsibility
PLeVasseur Apr 4, 2026
dd01b86
test(reviewer-bot): reduce fake runtime to a thin compatibility shell
PLeVasseur Apr 5, 2026
0f36579
test(reviewer-bot): align integration tests with fake runtime shell
PLeVasseur Apr 5, 2026
627399c
test(reviewer-bot): refine fake runtime compatibility delegation
PLeVasseur Apr 5, 2026
5b3b48f
test(reviewer-bot): converge transport fakes on shared authority
PLeVasseur Apr 5, 2026
a97080c
test(reviewer-bot): converge transport fakes on shared authority
PLeVasseur Apr 5, 2026
ad3faa3
test(reviewer-bot): wire fake runtime rest transport through github stub
PLeVasseur Apr 5, 2026
b302668
refactor(reviewer-bot): make state and lock seams strictly runtime-owned
PLeVasseur Apr 5, 2026
0ad2cbd
test(reviewer-bot): remove ambient env mirroring from fake config and…
PLeVasseur Apr 5, 2026
6a49fb4
test(reviewer-bot): restore review-state compatibility marker
PLeVasseur Apr 5, 2026
9a188ff
refactor(reviewer-bot): remove broad runtime github facade
PLeVasseur Apr 5, 2026
a58d9d8
refactor(reviewer-bot): align github services with slimmer runtime fa…
PLeVasseur Apr 5, 2026
e0eb727
refactor(reviewer-bot): remove broad runtime review and queue facade
PLeVasseur Apr 5, 2026
bcc7e23
refactor(reviewer-bot): thin bootstrap compatibility adapters
PLeVasseur Apr 5, 2026
5536618
refactor(reviewer-bot): split bootstrap adapter wiring by responsibility
PLeVasseur Apr 5, 2026
abb8e10
refactor(reviewer-bot): align callers with split bootstrap adapters
PLeVasseur Apr 5, 2026
1046d8e
test(reviewer-bot): move handler default ownership into focused fake …
PLeVasseur Apr 5, 2026
c133143
test(reviewer-bot): strengthen focused fake service ownership models
PLeVasseur Apr 5, 2026
90d1220
refactor(reviewer-bot): remove remaining optional runtime-owned infra…
PLeVasseur Apr 5, 2026
507434b
refactor(reviewer-bot): require logger and clock in orchestration hel…
PLeVasseur Apr 5, 2026
7534716
refactor(reviewer-bot): separate state and lock codec ownership
PLeVasseur Apr 5, 2026
a9bdd7a
refactor(reviewer-bot): split reconcile by payload and replay concern
PLeVasseur Apr 5, 2026
0278081
refactor(reviewer-bot): implement runbook-driven approval-pending det…
PLeVasseur Apr 5, 2026
ef96986
refactor(reviewer-bot): restore reconcile payload exports
PLeVasseur Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 0 additions & 115 deletions .github/reviewer-bot-tests/conftest.py
View file
Open in desktop

This file was deleted.

Loading
Loading