-
Notifications
You must be signed in to change notification settings - Fork 2
[DPE-1423] Update ocean-kubernetes-controller version to 0.1.59 #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Swap to the new published module for ocean
| drop: | ||
| - ALL | ||
|
|
||
| command: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to set command: []? Does it mean to use the default entry point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not exactly sure. Many of these changes are what the developers have as defaults, so I decided to leave them in.
In helm when you run
helm show values spot/ocean-kubernetes-controller
It gives you what their default values file is for the version you are using. The changes you see in the values file are what their new suggested defaults are, and I kept a bit of our specific configuration as well that isn't the same as the default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we usually just copy the template that they provide? I can find template here: https://artifacthub.io/packages/helm/spot/ocean-kubernetes-controller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah exactly! I do it through helm commands, but there are a bunch of places that we can get their template.
Copying the default template and adjusting it is how I have done all of the helm based deployments in the repo
| runAsUser: 10001 | ||
| runAsGroup: 10001 | ||
| fsGroup: 10001 | ||
| runAsUser: 1000690000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on my understanding, both 10001 and 1000690000 are both non-root users. Why do we need to switch from one non-root user to another?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… autoscaler module
thomasyu888
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM! Thanks for doing this update!


Problem:
Solution:
https://awslabs.github.io/amazon-eks-ami/nodeadm/
https://registry.terraform.io/providers/spotinst/spotinst/latest/docs/resources/ocean_aws#user_data-1
Testing: