-
Notifications
You must be signed in to change notification settings - Fork 2
[DPE-1423] Update ocean-kubernetes-controller version to 0.1.59 #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
4afdb13
73d2cd7
3237b5c
a8d4b75
a8bf626
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,8 +8,8 @@ spotinst: | |
| # -- Spot Token. (Required) | ||
| # Ref: https://docs.spot.io/administration/api/create-api-token | ||
| token: "" | ||
| # -- Spot Account. (Required) | ||
| # Ref: https://docs.spot.io/administration/organizations?id=account | ||
| # -- Spot Account ID. (Required) | ||
| # Example: `act-123abcd` | ||
| account: "" | ||
| # -- Unique identifier used by the Ocean Controller to connect (Required) | ||
| # between the Ocean backend and the Kubernetes cluster. | ||
|
|
@@ -25,15 +25,25 @@ spotinst: | |
| enableCsrApproval: true | ||
| # -- Disable automatic RightSizing. (Optional) | ||
| disableAutomaticRightSizing: false | ||
| # -- Disable TLS certificate validation. (Optional) | ||
| insecureSkipTLSVerify: false | ||
| # -- Sets the controller to read-only mode, removing write permissions and disabling autoscaling. (Optional) | ||
| readonly: false | ||
|
|
||
| # -- Configure the amount of replicas for the controller (Optional) | ||
| replicas: 2 | ||
|
|
||
| image: | ||
| repository: us-docker.pkg.dev/spotit-today/container-labs/spotinst-kubernetes-controller | ||
| pullPolicy: IfNotPresent | ||
| # Overrides the image tag whose default is the chart appVersion. | ||
| # -- Overrides the image tag whose default is the chart appVersion. | ||
| tag: "" | ||
| # -- Set to `true` to use an FIPS-140 compliant image. This flag adds `-fips` suffix to the image tag, | ||
| # therefore it should not be used together with the `--image.tag` flag. | ||
| # Ref: https://go.dev/doc/security/fips140 | ||
| fips: false | ||
|
|
||
| initContainers: [] | ||
|
|
||
| imagePullSecrets: [] | ||
|
|
||
|
|
@@ -79,9 +89,9 @@ commonLabels: {} | |
| # Ref: https://kubernetes.io/docs/concepts/security/pod-security-standards/ | ||
| podSecurityContext: | ||
| runAsNonRoot: true | ||
| runAsUser: 10001 | ||
| runAsGroup: 10001 | ||
| fsGroup: 10001 | ||
| runAsUser: 1000690000 | ||
| runAsGroup: 1000690000 | ||
| fsGroup: 1000690000 | ||
|
|
||
| # -- Priority class name for the controller pod. | ||
| priorityClassName: system-node-critical | ||
|
|
@@ -100,6 +110,8 @@ securityContext: | |
| drop: | ||
| - ALL | ||
|
|
||
| command: [] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we need to set
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not exactly sure. Many of these changes are what the developers have as defaults, so I decided to leave them in. In helm when you run
It gives you what their default values file is for the version you are using. The changes you see in the values file are what their new suggested defaults are, and I kept a bit of our specific configuration as well that isn't the same as the default.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we usually just copy the template that they provide? I can find template here: https://artifacthub.io/packages/helm/spot/ocean-kubernetes-controller
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah exactly! I do it through helm commands, but there are a bunch of places that we can get their template. Copying the default template and adjusting it is how I have done all of the helm based deployments in the repo |
||
|
|
||
| args: [] | ||
| # - --test | ||
|
|
||
|
|
@@ -190,8 +202,7 @@ metrics-server: | |
| pullPolicy: IfNotPresent | ||
|
|
||
| # -- Arguments to pass to metrics-server on start up. (Optional) | ||
| args: | ||
| - --logtostderr | ||
| # args: | ||
| # enable this if you have self-signed certificates, see: https://github.com/kubernetes-incubator/metrics-server | ||
| # - --kubelet-insecure-tls | ||
|
|
||
|
|
@@ -200,10 +211,12 @@ logShipping: | |
| # -- Specifies whether to send the controller logs to Spot for analysis. (Optional) | ||
| enabled: false | ||
|
|
||
| # -- Specifies the log shipping container image. (Optional) | ||
| image: | ||
| # -- Image repository. (Optional) | ||
| repository: ghcr.io/fluent/fluent-bit | ||
| tag: "3.0.7" | ||
| # -- Overrides the image tag. (Optional) | ||
| tag: "3.1.9" | ||
| # -- Image pull policy. (Optional) | ||
| pullPolicy: IfNotPresent | ||
|
|
||
| # -- Log shipping destination configuration. | ||
|
|
@@ -212,6 +225,26 @@ logShipping: | |
| port: 443 | ||
| tls: true | ||
|
|
||
| extraVolumeMounts: [] | ||
|
|
||
| extraEnv: [] | ||
|
|
||
| # -- Log shipping container command. (Optional) | ||
| command: | ||
| - /fluent-bit/bin/fluent-bit | ||
| - -c | ||
| - /tmp/fluent-bit.conf | ||
| - -q | ||
|
|
||
| # -- Log Shipping container security context | ||
| securityContext: | ||
| allowPrivilegeEscalation: false | ||
| readOnlyRootFilesystem: true | ||
| runAsNonRoot: true | ||
| capabilities: | ||
| drop: | ||
| - ALL | ||
|
|
||
| # Auto Update process configuration. | ||
| autoUpdate: | ||
| # -- Configures the image for the auto-updater job. (Optional) | ||
|
|
@@ -230,9 +263,9 @@ autoUpdate: | |
| # Ref: https://kubernetes.io/docs/concepts/security/pod-security-standards/ | ||
| podSecurityContext: | ||
| runAsNonRoot: true | ||
| runAsUser: 10001 | ||
| runAsGroup: 10001 | ||
| fsGroup: 10001 | ||
| runAsUser: 1000690000 | ||
| runAsGroup: 1000690000 | ||
| fsGroup: 1000690000 | ||
|
|
||
| # -- Security Context for the auto-updater container. (Optional) | ||
| securityContext: | ||
|
|
||

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on my understanding, both
10001and1000690000are both non-root users. Why do we need to switch from one non-root user to another?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I undestand why now! For some reasons, that was changed in their template:
