Skip to content

Conversation

@philerooski
Copy link
Contributor

No description provided.

@philerooski philerooski requested a review from a team as a code owner December 11, 2024 22:34
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM!

@philerooski
Copy link
Contributor Author

I filed a ticket here for the broken action: https://sagebionetworks.jira.com/browse/ETL-702

I will manually carry out the rest of the CI steps on Friday once I'm back.

password: ${{ needs.pytest-docker.outputs.ecr-password }}
env:
DISABLE_SSL: true
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to remove these modifications, I don't think these will work anymore

@sonarqubecloud
Copy link

@philerooski
Copy link
Contributor Author

Tests pass and branch can be successfully deployed with the new schedule.

@philerooski philerooski merged commit 6a9e4ae into main Dec 13, 2024
17 of 19 checks passed
@philerooski philerooski deleted the etl-701 branch December 13, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants