refactor(agora): remove legacy libraries and consolidate explorers shared components (AG-1847)#3889
Open
sagely1 wants to merge 2 commits intoSage-Bionetworks:mainfrom
Open
Conversation
…mponents - Make wikiParams a required input on wiki, popover-link, and modal-link components - Switch wiki component from effect-based to OnInit lifecycle for data fetching - Add isPlatformBrowser guard to wiki and terms-of-service components - Improve wiki/wiki-hero layout with flexbox for better loading state display - Convert wiki isLoading to signal for reactive state management - Add className input to wiki and wiki-hero components for external styling - Add heroBackgroundImagePath input to wiki-hero for customizable backgrounds - Fix logger service to not log undefined when optional data/error params are omitted - Add non-null assertion for optional headerTitleWikiParams in comparison-tool-header Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… shared components Remove the agora-specific about, news, and shared libraries that have been superseded by the explorers shared component library. Migrate all Agora components to use explorers equivalents for modal-link, popover-link, wiki, loading-icon, and svg-icon. - Delete libs/agora/about, libs/agora/news, libs/agora/shared - Delete SynapseApiService and SynapseWiki model (replaced by explorers equivalents) - Delete agora-specific popover-link component from genes library - Update all gene, comparison-tool, and nominated-target components to import from @sagebionetworks/explorers/util instead of @sagebionetworks/agora/shared - Route about/news pages through shared wiki-hero component - Add wiki-pages styles for about and news page content - Remove unused tsconfig path aliases - Update testing mocks to use explorers models Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5 tasks
sagely1
changed the title
sagely1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces legacy Agora components with newer explorers shared components.
Related Issues
AG-1847
Changelog
libs/agora/about,libs/agora/news, andlibs/agora/sharedlibraries (replaced by explorers shared components)SynapseApiService,SynapseWikimodel, and related test stubs@sagebionetworks/explorers/utilinstead of@sagebionetworks/agora/sharedwikiHeroRoutecomponentTest plan
@sagebionetworks/agora/shared