Skip to content

[SYNPY-1737] Switch urllib3 to version 2 #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BryanFauble merged 3 commits into from
Dec 31, 2025
Merged

[SYNPY-1737] Switch urllib3 to version 2 #1299

BryanFauble merged 3 commits into from
Dec 31, 2025

Conversation

@BryanFauble
Copy link
Member

@BryanFauble BryanFauble commented Dec 30, 2025 •
edited
Loading

Problem:

Solution:

  • Enforce a minimum of version 2 in SYNPY (urllib3)
  • Enforce a minimum version of 3.20.1 for filelock

Testing:

  • Will review integration test runs

@BryanFauble BryanFauble requested a review from a team as a code owner December 30, 2025 20:42
andrewelamb
andrewelamb reviewed Dec 30, 2025
View reviewed changes
andrewelamb
andrewelamb approved these changes Dec 30, 2025
View reviewed changes
Copy link
Contributor

@andrewelamb andrewelamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BryanFauble BryanFauble merged commit da0d125 into develop Dec 31, 2025
49 of 50 checks passed
@BryanFauble BryanFauble deleted the synpy-1737-upgrade-urllib3 branch December 31, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewelamb andrewelamb andrewelamb approved these changes

@brucehoff brucehoff Awaiting requested review from brucehoff

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BryanFauble @andrewelamb