Skip to content

[App Extensibility] Remove retail-react-app-demo preset in CI (@W-17597153@)#2204

Merged
bendvc merged 11 commits intofeature/extensibility-v2from
bendvc/W-17597153_update-github-actions
Jan 15, 2025
Merged

[App Extensibility] Remove retail-react-app-demo preset in CI (@W-17597153@)#2204
bendvc merged 11 commits intofeature/extensibility-v2from
bendvc/W-17597153_update-github-actions

Conversation

@bendvc
Copy link
Contributor

@bendvc bendvc commented Jan 14, 2025

Description

The retail-react-app-demo preset is used in github actions to generate a project and test it. This preset uses the template-reatil-react-app project which is going to be removed in the future in favour of using the extensions-chakra-storefront and the new extensibility model.

So, in this PR we are removing the aforementioned preset with retail-react-app-test-project.

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Changes

  • Update github actions

How to Test-Drive This PR

  • Just look at the github actions and see that generated projects using retail-react-app are passing.

This project is going away, so we don't need to run it in CI. Here we are going to replace it with the retail-react-app-test-project preset that uses the new extensibility model.
@bendvc bendvc added the skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated label Jan 14, 2025
@bendvc bendvc requested a review from a team as a code owner January 14, 2025 19:01
@bendvc bendvc changed the title [App Extensibility] Replace retail-react-app-demo preset in CI with retail-react-app-test-project (@W-17597153@) [App Extensibility] Rewmove retail-react-app-demo preset in CI (@W-17597153@) Jan 14, 2025
@bendvc bendvc changed the title [App Extensibility] Rewmove retail-react-app-demo preset in CI (@W-17597153@) [App Extensibility] Remove retail-react-app-demo preset in CI (@W-17597153@) Jan 14, 2025
@bendvc bendvc merged commit 55292be into feature/extensibility-v2 Jan 15, 2025
24 checks passed
@bendvc bendvc deleted the bendvc/W-17597153_update-github-actions branch July 16, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants