Skip to content

[App Extensibility] Remove retail-react-app-demo preset in CI (@W-17597153@) #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bendvc merged 11 commits into from
Jan 15, 2025
Merged

[App Extensibility] Remove retail-react-app-demo preset in CI (@W-17597153@) #2204

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
da0bce2
Remove `retail-react-app-demo` from ci actions.
bendvc Jan 14, 2025
0a913df
Remove dupe preset
bendvc Jan 14, 2025
79e79d8
Add missing cross-env dep
bendvc Jan 14, 2025
720cc97
Fix script executing to work on windows.
bendvc Jan 14, 2025
f4bb229
Support windows paths with spaces
bendvc Jan 14, 2025
ae8b943
Attempt fix for loader not working on windows.
bendvc Jan 14, 2025
c982ab8
Attempt #2 for fix paths
bendvc Jan 14, 2025
fbea6de
Clean up fix
bendvc Jan 15, 2025
d9cffee
Drop overage after fix. Will bump back up in testing uplift ticket
bendvc Jan 15, 2025
8e53555
Update CHANGELOG.md to force ci rerun
bendvc Jan 15, 2025
0bc3a84
Delete loadable-stats.json
bendvc Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,10 +184,10 @@ jobs:
strategy:
fail-fast: false
matrix:
template: [retail-react-app-test-project, retail-react-app-demo, express-minimal-test-project, typescript-minimal-test-project]
template: [retail-react-app-test-project, express-minimal-test-project, typescript-minimal-test-project]
runs-on: ubuntu-latest
env:
IS_TEMPLATE_FROM_RETAIL_REACT_APP: ${{ matrix.template == 'retail-react-app-test-project' || matrix.template == 'retail-react-app-demo' }}
IS_TEMPLATE_FROM_RETAIL_REACT_APP: ${{ matrix.template == 'retail-react-app-test-project' }}
PROJECT_DIR: generated-${{ matrix.template }}
steps:
- name: Checkout
Expand Down Expand Up @@ -282,10 +282,10 @@ jobs:
strategy:
fail-fast: false
matrix:
template: [retail-react-app-test-project, retail-react-app-demo, express-minimal-test-project, typescript-minimal-test-project]
template: [retail-react-app-test-project, express-minimal-test-project, typescript-minimal-test-project]
runs-on: windows-latest
env:
IS_TEMPLATE_FROM_RETAIL_REACT_APP: ${{ matrix.template == 'retail-react-app-test-project' || matrix.template == 'retail-react-app-demo' }}
IS_TEMPLATE_FROM_RETAIL_REACT_APP: ${{ matrix.template == 'retail-react-app-test-project' }}
PROJECT_DIR: generated-${{ matrix.template }}
steps:
- name: Checkout
Expand Down
96 changes: 96 additions & 0 deletions packages/template-typescript-minimal/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/template-typescript-minimal/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
"@types/react": "~18.2.0",
"@types/react-dom": "~18.2.1",
"@types/react-router-dom": "~5.3.3",
"cross-env": "^5.2.1",
"framer-motion": "^11.5.4",
"react": "^18.2.0",
"react-dom": "^18.2.0",
Expand Down
Loading