Skip to content

@W-17907321 Fix server-timing header delimiter#2295

Merged
kevinxh merged 4 commits intodevelopfrom
W-17907321_server-timing-delimiter
Mar 3, 2025
Merged

@W-17907321 Fix server-timing header delimiter#2295
kevinxh merged 4 commits intodevelopfrom
W-17907321_server-timing-delimiter

Conversation

@kevinxh
Copy link
Contributor

@kevinxh kevinxh commented Mar 3, 2025

Description

This PR fixes and issue where the Server-Timing header used invalid http delimiter, this PR replaces the : delimiter using .

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • Fix server timing header delimiter

How to Test-Drive This PR

  • npm start
  • go to localhost:3000?__server_timing
  • check http response header

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@kevinxh kevinxh requested a review from a team as a code owner March 3, 2025 17:30
@vcua-mobify
Copy link
Contributor

Screenshot 2025-03-03 at 10 13 32 AM

The changes look good to me. I can see the new delimiter in the response headers

vcua-mobify
vcua-mobify previously approved these changes Mar 3, 2025
Copy link
Contributor

@adamraya adamraya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update the delimiter used in withLegacyGetProps?

res.__performanceTimer.mark(
`${PERFORMANCE_MARKS.getProps}::${templateName}`,
'start'
)
})
return c.getProps
? c
.getProps({
req,
res,
params,
location
})
.then((result) => {
c.getTemplateName().then((templateName) => {
res.__performanceTimer.mark(
`${PERFORMANCE_MARKS.getProps}::${templateName}`,

Copy link
Contributor

@adamraya adamraya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinxh
Copy link
Contributor Author

kevinxh commented Mar 3, 2025

@kevinxh kevinxh merged commit 3f4bbff into develop Mar 3, 2025
35 checks passed
@kevinxh kevinxh deleted the W-17907321_server-timing-delimiter branch March 3, 2025 19:35
@kevinxh kevinxh mentioned this pull request Mar 12, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants