@W-18767088 refactor add to cart by sf-kyle-wright · Pull Request #2664 · SalesforceCommerceCloud/pwa-kit

sf-kyle-wright · 2025-06-26T18:03:10Z

Description

Extracting existing add to cart functions from pdp into re-usable util file

Types of Changes

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Documentation update
Breaking change (could cause existing functionality to not work as expected)
Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

Removing a public function or component or prop

Adding a required argument to a function

Changing the data type of a function parameter or return value

Adding a new peer dependency to package.json

Changes

(change1)

How to Test-Drive This PR

Execute existing tests to verify that nothing is broken
Verify Add to Cart on PDP still works as expected

Checklists

General

Changes are covered by test cases
CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

There are no changes to UI

or...

Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
Changes comply with WCAG 2.0 guidelines levels A and AA
Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

Changes include a UI text update in the Retail React App (which requires translation)

cc-prodsec · 2025-06-26T18:03:20Z

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

sf-emmyzhang

Assuming we want to move the unit tests over too?

sf-kyle-wright · 2025-06-26T18:16:32Z

Assuming we want to move the unit tests over too?

Ya I'll do that in a few. Wanted to get feedback on the approach

sf-deepali-bharmal · 2025-06-26T18:49:06Z

packages/template-retail-react-app/app/utils/cart-utils.js

+ */
+
+/**
+ * Handles adding products to cart and sending data to Einstein.


@sf-kyle-wright The WI description mentioned one reason to move addToCart out is it can be used from multiple clients like PDP, wishlist etc.
Then utils/cart-utils does not seem the right place to me.
Should this be a hook or something like that instead ?
Hooks can contain logic for data fetching, state management, UI behavior etc.

Ya so that's a great thought. There are some tradeoffs here but it looks like at this point it might not make sense to move them into a hook. I asked cursor, TLDR:

Summary: It doesn't strictly make sense to turn these into a hook unless you want to manage state or context, or provide a more React-friendly API. If you do, a hook can be a good abstraction, but the current logic itself doesn't require it.

cursor_should_i_convert_util_functions.md

sf-deepali-bharmal · 2025-06-26T18:51:39Z

packages/template-retail-react-app/app/pages/product-detail/index.jsx

-    }
-
-    /**************** Product Set/Bundles Handlers ****************/
-    const handleChildProductValidation = useCallback(() => {


Do we need to move this as well ? If Yes, this can go in some util file.
Others can go in some AddToCart hook/or something, as they are all Adding diff products to cart.

handleChildProductValidation - Moved it back to product-detail since it didn't make sense to extract this one to the util

sf-kyle-wright · 2025-06-26T21:52:11Z

There are currently no tests that directly test handleAddToCart, handleProductBundleAddToCart, or handleProductSetAddToCart. I will create dedicated tests for each of these in a follow up PR

…factor-add-to-cart Signed-off-by: Kyle Wright <30636085+sf-kyle-wright@users.noreply.github.com>

patricksullivansf · 2025-06-26T22:26:58Z

Fair warning, this refactor isn't compatible with BOPIS, add to cart needs much more data passed in. see https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2646/files#r2170144721

alexvuong · 2025-06-26T23:42:20Z

packages/template-retail-react-app/app/utils/cart-utils.js

+ */
+
+/**
+ * Handles adding products to cart and sending data to Einstein.


since this is only working on cart? How about we keep it in cart page? Unless we have plan for these funcs to be used by other components that is not cart

There is a larger plan to re-use these functions across wishlist as well

if that is the case, let's name the file to be a bit more generic.

@alexvuong What do you have in mind?

add-to-cart-utils?

I like that name @sf-emmyzhang

thanks. renamed to add-to-cart-utils.js

@W-18767088 refactor add to cart

f0f10d6

sf-kyle-wright requested a review from a team as a code owner June 26, 2025 18:03

@W-18767088 refactor add to cart

f241f49

sf-kyle-wright requested review from a team, jeremy-jung1 and sf-emmyzhang June 26, 2025 18:07

sf-emmyzhang reviewed Jun 26, 2025

View reviewed changes

@W-18767088 fix lint errors

f545efe

sf-deepali-bharmal reviewed Jun 26, 2025

View reviewed changes

@W-18767088 do not move handleChildProductValidation

dd72f4f

Merge branch 'standard-product-support' into t/cc-shark/W-18767088/re…

a637f3b

…factor-add-to-cart Signed-off-by: Kyle Wright <30636085+sf-kyle-wright@users.noreply.github.com>

patricksullivansf mentioned this pull request Jun 26, 2025

@W-18811979 BOPIS (buy online pick up in store) #2646

Merged

12 tasks

alexvuong reviewed Jun 26, 2025

View reviewed changes

ddiazccrz approved these changes Jun 27, 2025

View reviewed changes

sf-deepali-bharmal approved these changes Jun 27, 2025

View reviewed changes

sf-jhalak-maheshwari approved these changes Jun 27, 2025

View reviewed changes

@W-18767088 utils rename

f73f650

sf-kyle-wright merged commit eea4a61 into standard-product-support Jun 27, 2025
35 checks passed

sf-emmyzhang mentioned this pull request Jul 1, 2025

Merge standard products feature into develop @W-18912410 #2697

Merged

12 tasks

Conversation

sf-kyle-wright commented Jun 26, 2025

Description

Types of Changes

Changes

How to Test-Drive This PR

Checklists

General

Accessibility Compliance

Localization

Uh oh!

cc-prodsec commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎉 Snyk checks have passed. No issues have been found so far.

Uh oh!

sf-emmyzhang left a comment

Choose a reason for hiding this comment

Uh oh!

sf-kyle-wright commented Jun 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sf-kyle-wright commented Jun 26, 2025

Uh oh!

patricksullivansf commented Jun 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

cc-prodsec commented Jun 26, 2025 •

edited

Loading