Merge standard products feature into develop @W-18912410

[sf-emmyzhang]

Description

This PR is merging all the standard product feature work into develop. See "How to Test-Drive This PR" below for all the relevant PRs

Types of Changes

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Documentation update
• Breaking change (could cause existing functionality to not work as expected)
• Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

• Removing a public function or component or prop
• Adding a required argument to a function
• Changing the data type of a function parameter or return value
• Adding a new peer dependency to package.json

Changes

• (change1)

How to Test-Drive This PR

MRT Env: https://cc-sharks-standard-product.mobify-storefront-staging.com
PRs included in this feature branch:

• Support standard product on PDP @W-12360908
• @W-12360935 Modify the Product Card to support standard products
• @W-12360935 2nd PR- fixing Edit button appearing briefly for standard products
• Support standard product as a child item in bundles @W-18790730
• Support standard product as a child item in sets @W-18790730
• @W-17118204 Verify einstein activity for Standard Product
• @W-18767088 refactor add to cart

Test steps:

Happy path

2. Go to home page, clear site data, and refresh and press accept on consent tracking. Open Network tab and put in "cquotient". Then go to standard product and see that: viewProduct, pdp-similar-items, complete-the-set, viewReco requests are being made. viewReco will come up if you scroll down to the bottom of PDP.
3. Have network tab still open. Add standard product to cart. See that addToCart cquotient call is made. And check out
4. Add standard product to wish list from the PDP and PLP
5. Add bundle with standard product to cart and checkout also add it to wish list
6. Add set with standard product to cart and checkout also add it to wish list

Out of stock handling

1. See that out of stock standard product shows that it's out of stock
2. See that a bundle with out of stock standard product shows out of stock
3. See that a set with out of stock standard product shows out of stock

Note: Adding an out of stock product in the wishlist, not limited to standard product, in the develop code currently gives a "Something went wrong" error message. This behavior existed before and is not blocking for this PR.

Checklists

General

• Changes are covered by test cases
• CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

• There are no changes to UI

or...

• Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
• Changes comply with WCAG 2.0 guidelines levels A and AA
• Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

• Changes include a UI text update in the Retail React App (which requires translation)

[patricksullivansf]

hi, @sf-emmyzhang we just removed this change in #2729. Is there a benefit to adding it back?

[sf-emmyzhang]

Product is part of standard product changes and is needed for standard products to work

[patricksullivansf]

Hmm... before BOPIS or standard-product the product was added as a lambda in the parent container addToCart handler in pages/product-detail. And a childProduct was added in the parent for product sets and bundles. My worry is with this change back that bundles and sets will not work properly.

[jeremy-jung1]

Updated the code to account for both features (commit)

[patricksullivansf]

nit: for the record I still don't think this change is needed nor advisable. We're changing the data contract between product-view and product-detail, which implies more merge work for custom implementations. There should be a good reason.

[patricksullivansf]

Guessing we don't want this change either as it would associate product sets with the parent instead of the child, no?

[sf-emmyzhang]

@jeremy-jung1 Can you help explain this change? Is this related to the 400 error?

[jeremy-jung1]

Yes this was the fix for a 400 error that occurred when trying to add a standard product child item in a set to cart. The childProduct is passed in via the <ProductView/> component because it received the childProduct via the product prop and passes that in when calling addToCart.

Before the parameters passed into handleAddToCart was just (variant, quantity) which isn't the correct shape as how the function is used in ProductView.

[vmarta]

There's a bug with adding to wishlist when you're initially a guest shopper. After logging in, we automatically tried to mutate/update the wishlist but ran into a js undefined error.

What the expected result is:

• successful login ← it's good
• and also successfully added to the wishlist ← failed here

Here's a video to reproduce the bug:

Arc.2025-07-08.at.13.32.19.mp4

[sf-emmyzhang]

There's a bug with adding to wishlist when you're initially a guest shopper. After logging in, we automatically tried to mutate/update the wishlist but ran into a js undefined error.

I followed these steps to repro, on my local but it seems to be working for me. Did you test on the standard product MRT env? It's possible that we need to deploy again.

[vmarta]

Non-blocking: I see a lot of places where we check for variant or standard products... it requires us to do this check in all places that need it.

In the future, it'd be great to normalize the product data in 1 place initially. For example, according to AI:

// At the boundary - normalize immediately
const normalizeProductSelection = (variant, product) => {
  // Always return same shape, no matter what input look like
  return {
    id: variant?.productId || product?.id,
    price: variant?.price || product?.price,
    name: variant?.name || product?.name,
    orderable: variant?.orderable || product?.inventory?.orderable,
    stockLevel: variant?.stockLevel || product?.inventory?.stockLevel,
    isStandardProduct: !variant,
    isVariantProduct: !!variant,
    originalVariant: variant,
    originalProduct: product
  }
}

// Now everywhere else in code - simple!
const addToCart = (normalizedProduct, quantity) => {
  return {
    productId: normalizedProduct.id,  // No more conditionals!
    price: normalizedProduct.price,   // Simple!
    quantity
  }
}

// Validation becomes obvious
const validateOrderability = (normalizedProduct, quantity) => {
  return normalizedProduct.orderable && 
         quantity > 0 && 
         quantity <= normalizedProduct.stockLevel
}

[vmarta]

There's a bug with adding to wishlist when you're initially a guest shopper. After logging in, we automatically tried to mutate/update the wishlist but ran into a js undefined error.

I followed these steps to repro, on my local but it seems to be working for me. Did you test on the standard product MRT env? It's possible that we need to deploy again.

@sf-emmyzhang yes, I tested on the MRT environment listed in the PR description.

[vmarta]

With the latest deployed env, I'm still seeing the issue with adding to wishlist as a guest user. Perhaps it's a race condition that I was able to run into consistently?

It's strange how the Welcome message does not have my name in it. Maybe it's related to the js undefined error somehow.

Arc.2025-07-09.at.11.18.57.mp4

But anyways, let's create a ticket (or however you'd like to track it).

Other than that, this PR looks good to me.

[ddiazccrz]

Small knit, but maybe just put the last PR (this one) in the changelog, i dont think we ended up adding all the statements for the other features.

[ddiazccrz]

This PR did not make it in to develop, so this needs to be pulled