@W-18903896 do not trigger bonus modal for rule based promotions - MVP#2674
Merged
sf-madhuri-uppu merged 4 commits intofeature/bonus-productsfrom Jun 27, 2025
Merged
@W-18903896 do not trigger bonus modal for rule based promotions - MVP#2674sf-madhuri-uppu merged 4 commits intofeature/bonus-productsfrom
sf-madhuri-uppu merged 4 commits intofeature/bonus-productsfrom
Conversation
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
sf-madhuri-uppu
added
skip changelog
ddiazccrz
reviewed
Jun 27, 2025
| if (isValidResponse) { | ||
| // Show bonus product modal first if there are bonus items | ||
| if (newBonusItems?.length > 0) { | ||
| // TODO: rule based promotions will be handled after Product Discovery team delivers TD-0262468 |
Contributor
There was a problem hiding this comment.
Can we just say that we dont support rule base yet, this will go out to devlop and the release before that TD is delivered most likely
Contributor
There was a problem hiding this comment.
Also any test updates or anything we can do here?
Contributor
Author
There was a problem hiding this comment.
@ddiazccrz Sure updated the comment and added a test
ddiazccrz
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-06-27.at.12.18.15.PM.mov
Description
Bonus modal should not pop up for rule based promotions for MVP till Product discovery team delivers the TD
TD on Product discovery team - https://gus.lightning.force.com/lightning/r/ADM_Team_Dependency__c/a0nEE000000rllZYAQ/view
PR for rule based promotions - #2641
Will be merged after the TD is delivered
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization