Skip to content

@W-18903896 do not trigger bonus modal for rule based promotions - MVP #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sf-madhuri-uppu merged 4 commits into from
Jun 27, 2025
Merged

@W-18903896 do not trigger bonus modal for rule based promotions - MVP #2674

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d7e6c6b
do not trigger bonus modal for rule based promotions - MVP
sf-madhuri-uppu Jun 27, 2025
61d5d99
skip changelog
sf-madhuri-uppu Jun 27, 2025
3fe94bc
skip changelog
sf-madhuri-uppu Jun 27, 2025
bffbcc6
updated a test
sf-madhuri-uppu Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/template-retail-react-app/app/components/product-view/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,11 @@ const ProductView = forwardRef(
// See wishlist_primary_action for example.
if (isValidResponse) {
// Show bonus product modal first if there are bonus items
if (newBonusItems?.length > 0) {
// TODO: rule based promotions will be handled after Product Discovery team delivers TD-0262468
Copy link
Contributor

@ddiazccrz ddiazccrz Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just say that we dont support rule base yet, this will go out to devlop and the release before that TD is delivered most likely

Copy link
Contributor

@ddiazccrz ddiazccrz Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also any test updates or anything we can do here?

Copy link
Contributor Author

@sf-madhuri-uppu sf-madhuri-uppu Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddiazccrz Sure updated the comment and added a test

if (
newBonusItems?.length > 0 &&
newBonusItems.some((item) => item.bonusProducts)
) {
// Update bonusProducts list with the new bonus items
addBonusProducts(newBonusItems)
onBonusProductModalOpen({
Expand Down
Loading