-
Notifications
You must be signed in to change notification settings - Fork 212
@W-18992617@ - Revert test product changes for e2e tests #2761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
b018dcb
2fe2b1f
cd5f4dc
58ec3a7
60f43f7
de2a00c
9c6e038
293312f
1646905
7da66c8
4b17de4
811d4c8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,7 @@ | |
| "helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright", | ||
| "nodes": [ | ||
| { | ||
| "html": "<a class=\"...\" aria-label=\"Back to cart, number of items: 2\" href=\"/global/en-GB/cart\">", | ||
| "html": "<a class=\"...\" aria-label=\"Back to cart, number of items: 2\" href=\"/cart\">", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this correct? No multisite?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah. The generated app has site and locale in config/default.js both set to none and no siteAliases defined. That's just a monorepo thing. So when the previous PR updated snapshots, it probably did it against the buggy generator which was ignoring generator templates and falling back to use the monorepo defaults.
|
||
| "failureSummary": "Fix any of the following:\n Some page content is not contained by landmarks", | ||
| "target": [ | ||
| ".css-1k2aozt" | ||
|
|
||

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍