@W-18992617@ - Revert test product changes for e2e tests#2761
@W-18992617@ - Revert test product changes for e2e tests#2761
Conversation
shethj
added
the
skip changelog
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
| "failureSummary": "Fix any of the following:\n Some page content is not contained by landmarks", | ||
| "target": [ | ||
| "#popover-trigger-\\:R1l4lb9rlbpH1\\: > .css-1igwmid.chakra-stack > .chakra-input__group.css-1y0e7gb > .css-va76oz" | ||
| "#popover-trigger-\\:rh\\:" |
| "nodes": [ | ||
| { | ||
| "html": "<a class=\"...\" aria-label=\"Back to cart, number of items: 2\" href=\"/global/en-GB/cart\">", | ||
| "html": "<a class=\"...\" aria-label=\"Back to cart, number of items: 2\" href=\"/cart\">", |
There was a problem hiding this comment.
is this correct? No multisite?
There was a problem hiding this comment.
Yeah. The generated app has site and locale in config/default.js both set to none and no siteAliases defined. That's just a monorepo thing. So when the previous PR updated snapshots, it probably did it against the buggy generator which was ignoring generator templates and falling back to use the monorepo defaults.
| "failureSummary": "Fix any of the following:\n Some page content is not contained by landmarks", | ||
| "target": [ | ||
| ".chakra-portal:nth-child(10)" | ||
| ] |
There was a problem hiding this comment.
We got rid of one and added new one
There was a problem hiding this comment.
It was a false update. Apparently when I last updated the snapshot there were still some other things broken.
Now all other tests pass and I updated the snapshot again and exactly this change reverted back.
So we should be good to go. Thanks for catching this.
4 participants
Description
With BOPIS changes and generator changes merged into develop we started seeing test failures stating the product e2e tests were looking for no longer exists. Assuming some code change modified sort order and the previous test product no-longer renders on the first page we merged a code change to use a different product in #2716
Turns out the product wasn't found because of a bug in the generator that ignored any config passed in via the questions and always generated a retail app pointing to the default BM instance in the monorepo. That is why the tests couldn't find the product.
The generator issue has been fixed and merged: #2751
So this PR reverts the test product changes to continue using the one configured in the CI instance.
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization