-
Notifications
You must be signed in to change notification settings - Fork 205
@W-20448811 Shopper can manually enter OTP in login flows #3554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hajinsuha1
wants to merge
15
commits into
feature/email-otp
Choose a base branch
from
W-20448811-shopper-can-manually-enter-otp-in-login-flows-2
base: feature/email-otp
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
@W-20448811 Shopper can manually enter OTP in login flows #3554
hajinsuha1
wants to merge
15
commits into
feature/email-otp
from
W-20448811-shopper-can-manually-enter-otp-in-login-flows-2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
12 tasks
12 tasks
…n and updating related components. Adjust OTP input fields in the OtpAuth component to reflect the token length from configuration.
…-enter-otp-in-login-flows-2 Signed-off-by: Jinsu Ha <[email protected]>
* Add passwordless login OTP verification to desktop and mobile e2e tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow shopper to manually input the OTP during the passwordless login flow by displaying an OTP Auth modal after clicking "Continue Securely".
Screenshare.-.2025-12-31.2_31_41.PM.mp4
Types of Changes
Changes
Checkout as GuestbuttonHow to Test-Drive This PR
Auth Modal
Login Page
Magic Link
Token Length is configurable
tokenLengthto6E2E Tests
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization