-
Notifications
You must be signed in to change notification settings - Fork 212
@W-20448811 Shopper can manually enter OTP in login flows #3554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hajinsuha1
merged 104 commits into
develop
from
W-20448811-shopper-can-manually-enter-otp-in-login-flows-2
Feb 4, 2026
Merged
Changes from 94 commits
Commits
Show all changes
104 commits
Select commit
Hold shift + click to select a range
7877887
@W-20279798 support setting passwordless login mode in config (#3492)
hajinsuha1 22b6a36
Merge branch 'develop' into feature/email-otp
hajinsuha1 c646e44
@W-20443849 Set default passwordless mode to 'email' for apps created…
hajinsuha1 bd6d1d0
Merge branch 'develop' into feature/email-otp
hajinsuha1 a903665
One click checkout
syadupathi-sf 1e7e5fd
changes to fix install, tests and lint - needs to be reviewed
syadupathi-sf b707b09
Change log
syadupathi-sf a72864b
revert the test change in pwa-kit-runtime
syadupathi-sf 0fd5d2c
Change commerce-sdk-react package-lock in an attempt to get the CI wo…
syadupathi-sf fdb57a2
Increase bundle size of template-retail-react-app by 1KB
syadupathi-sf f005c92
pull in OTP Auth modal changes from 1 click checkout feature branch
hajinsuha1 65dfe27
integrate OTPAuth modal in login flows
hajinsuha1 434ae12
update passwordless login component to not hide fields when submit is…
hajinsuha1 78fd7e2
add back changes made in feature/email-otp branch
hajinsuha1 a0343e9
remove redundant calls to merge basket
hajinsuha1 d9a6b12
move handleMergeBaskets to a custom hook
hajinsuha1 823ac62
add unit tests
hajinsuha1 d56b87a
update changelog
hajinsuha1 d34ec56
Revert "move handleMergeBaskets to a custom hook"
hajinsuha1 11be87e
@W-20342599 Password Reset uses `email` mode (#3547)
hajinsuha1 4d1a5aa
Enhance passwordless login configuration by adding token length optio…
hajinsuha1 355bc0d
@W-20542850 Remove promotion from Shipping Method summary view (#3563)
syadupathi-sf d9ed864
@W-20279800 Update Passwordless E2E tests and change "Continue Secure…
hajinsuha1 229221c
Merge branch 'feature/email-otp' into W-20448811-shopper-can-manually…
hajinsuha1 f032e1c
update translations
hajinsuha1 e73c04c
update pwa-kit-create-app changelog
hajinsuha1 cd05b1f
fix translations
hajinsuha1 96f1b89
W-19728108 Add amount to payment instrument in the basket (#3568)
syadupathi-sf 77d1147
E2E test updates Passwordless login manual input of OTP (#3558)
hajinsuha1 07802f3
Merge branch 'develop' into feature/email-otp
hajinsuha1 c0aedcb
lint
hajinsuha1 f773ee4
Move tokenLength configuration from passwordless to login for future …
hajinsuha1 3d27d0b
fix incorrect resetPasswordLandingPath in usePasswordReset after merg…
hajinsuha1 e49c9be
Merge branch 'develop' into feature/email-otp
hajinsuha1 3cfece1
fix failing unit test after merge from develop
hajinsuha1 5c8c6ce
W-19728108 Amount for the registered shopper (#3572)
syadupathi-sf c02836d
Merge branch 'develop' into feature/email-otp
hajinsuha1 8fd1ab2
W-20892453 Remove store pickup shipping option (#3575)
syadupathi-sf 81973db
@W-20892497 Show Phone number in Contact Info summary (#3576)
syadupathi-sf 128ccd5
@W-20892554 Show spinner when user registration checkbox is clicked (…
syadupathi-sf a5deb6c
@W-20892592 Remove gift messaging for multi shipment (#3579)
syadupathi-sf 3d79932
@W-20890250 Handle request limit and monthly quota error states for p…
hajinsuha1 892ef8c
Merge branch 'develop' into feature/email-otp
hajinsuha1 80c1c80
@W-20892530 @W-20892577 Billing Address Validation and Using contact …
syadupathi-sf 0e79176
Merge branch 'develop' into feature/1cc_merge
syadupathi-sf a0d8325
@W-20931438 Add spinner for place order button (#3587)
syadupathi-sf 35a9a4d
Update isomorphic version to the newly released version (#3592)
syadupathi-sf d6fe32c
Merge branch 'develop' into feature/1cc_merge
syadupathi-sf b9cb29d
Fix SDK tests (#3593)
syadupathi-sf 076b1ac
refactor auth so locale is sent via parameters instead of in the Auth…
hajinsuha1 b0ca814
Refactor URL handling by replacing buildAbsoluteUrl with absoluteUrl …
hajinsuha1 3c05026
Merge branch 'develop' into feature/email-otp
hajinsuha1 36e1b20
Update error message when shopper exceedes request limit for password…
hajinsuha1 3e9e385
Merge branch 'feature/email-otp' of https://github.com/SalesforceComm…
hajinsuha1 b7515c4
@W-20931758 Allow guest shopper to change payment (#3591)
syadupathi-sf abff98d
Apply suggestion from @alexvuong
hajinsuha1 c292a78
@W-21000333: [BOPIS] Should skip pick up address (#3601)
dannyphan2000 fe0a623
address feedback:
hajinsuha1 5f31e30
Merge branch 'feature/email-otp' of https://github.com/SalesforceComm…
hajinsuha1 bc6f621
lint
hajinsuha1 9fa4455
W-21005962 Disable user registration when billing address is not vali…
syadupathi-sf 411fc67
@W-21000338: [BOPIS] Auto-populate billing address with default addre…
dannyphan2000 dbb914e
@W-21006290: [BOPIS] Continue to Shipping Address label fix for BOPIS…
dannyphan2000 9c618de
@W-21000344: [BOPIS] Pickup address component enhancement (#3607)
dannyphan2000 753f306
W-21005976 Newly registered user can change payment (#3608)
syadupathi-sf c766b59
Merge branch 'develop' into feature/email-otp
hajinsuha1 f4852df
update copyright date for new files
hajinsuha1 7b6ee61
Merge branch 'feature/email-otp' into W-20448811-shopper-can-manually…
hajinsuha1 57d8961
Update OTP token length configuration to allow environment variable o…
hajinsuha1 6f45d2b
Refactor authentication modal tests and cleanup unused constants
hajinsuha1 32106db
Merge branch 'develop' into W-20448811-shopper-can-manually-enter-otp…
hajinsuha1 4f04c56
@W-21038080: [1CC][PWA] Add new feature toggle in config to template …
dannyphan2000 e8ffba8
Refactor error handling in authentication flows to use new error mess…
hajinsuha1 c672d31
Enhance OTP input field configuration and validation
hajinsuha1 8a25361
@W-21038080: Rework to use billing address phone number for guest sho…
dannyphan2000 aff72eb
@ W-20540715 Address 1CC feature branch review comments (#3619)
syadupathi-sf b73115a
Merge branch 'develop' into feature/1cc_merge
syadupathi-sf 44b2347
test
syadupathi-sf 7ed0da9
passwordless mode updates
syadupathi-sf e6b9f3d
fix unit test
syadupathi-sf 2720a5c
Merge branch 'feature/1cc_merge' into W-20448811-shopper-can-manually…
hajinsuha1 25e4f4f
increase bundle size of template-retail-react-app
hajinsuha1 34507b7
update translations
hajinsuha1 23a40e4
lint
hajinsuha1 77551f2
@W-20892603: Remove empty shipment fix (#3622)
dannyphan2000 3c2123a
Merge branch 'feature/1cc_merge' into W-20448811-shopper-can-manually…
hajinsuha1 0f6b842
Fix contact-info page not showing check your email modal when one-cli…
hajinsuha1 88419a6
reset form only if view is not email
hajinsuha1 bef76be
revert unnecessary changes made in login/index.jsx
hajinsuha1 60d3614
Update error handling in one-click contact info component to use the …
hajinsuha1 6649505
Update packages/template-retail-react-app/app/pages/checkout-one-clic…
syadupathi-sf 5144503
revert to generic error message as per code review comment
syadupathi-sf 2a74e96
console warn for null and undefined token lengths
hajinsuha1 e3c6e53
Merge branch 'feature/1cc_merge' into W-20448811-shopper-can-manually…
hajinsuha1 93c68c5
Merge branch 'develop' into W-20448811-shopper-can-manually-enter-otp…
hajinsuha1 482cd49
Add comment to default.js about tokenLength
hajinsuha1 babac43
Refactor OTP token length validation handling in default.js. Remove r…
hajinsuha1 ebdac22
add back in validation in otp-auth
hajinsuha1 b542c8d
lint
hajinsuha1 9cec46e
Merge branch 'develop' into W-20448811-shopper-can-manually-enter-otp…
hajinsuha1 88643c6
fix merge errors
hajinsuha1 cd0d3d1
update pwa-kit-create-app utils.js with validateOtpTokenLength method
hajinsuha1 644928d
update pwa-kit-create-app @salesforce/retail-react-app/config/utils.j…
hajinsuha1 c3752d2
Merge branch 'develop' into W-20448811-shopper-can-manually-enter-otp…
hajinsuha1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thank you for updating the E2E tests too.