Skip to content

Conversation

@hajinsuha1
Copy link
Collaborator

@hajinsuha1 hajinsuha1 commented Jan 2, 2026

Description

Update extra-features.spec.js to verify email mode is used by default for passwordless and password reset.
PR #3557 contains the changes in the branch used for E2E tests which will be merged after the feature branch is merged.

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • update extra-features.spec.js to verify email mode is used by default for passwordless and password reset

How to Test-Drive This PR

  • Start the playwright tests
    # Set the playwright tests to run against a `template-retail-react-app` with the new email OTP feature
    export [email protected] PWA_E2E_USER_PASSWORD=hpv_pek-JZK_xkz0wzf EXTRA_FEATURES_E2E_RETAIL_APP_HOME=https://wasatch-mrt-passwordless-test.mrt-storefront-staging.com
    
    npx playwright test --project=extra-features-desktop --project=extra-features-mobile --ui
    
  • Verify all tests (desktop and mobile) pass except Verify password reset callback request on mobile when extra login features are not enabled. This tests fails as it runs against https://scaffold-pwa-e2e-pwa-kit-private.mobify-storefront.com/ which does not have the email otp changes yet
    Screenshot 2026-01-02 at 3 17 49 PM

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Jan 2, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@hajinsuha1 hajinsuha1 changed the title @W-20279800 Update Passwordless E2E tests @W-20279800 Update Passwordless E2E tests and change "Continue Securely" to "Continue" Jan 6, 2026
@hajinsuha1 hajinsuha1 merged commit d9ed864 into feature/email-otp Jan 8, 2026
42 checks passed
@hajinsuha1 hajinsuha1 deleted the W-20279800-update-passwordless-e2e-tests branch January 8, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants