[DO NOT MERGE] Feature: Passwordless Login and Password Reset supports use of email mode
#3525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add passwordless login mode configuration with email as default * Update authorizePasswordless to require mode parameter and add locale support * Remove commented out passwordless callbackURI configuration * Remove passwordlessCallbackURI variable and simplify callbackURI condition in authorizePasswordlessLogin * Remove conditional callbackURI spread and add mode parameter to checkout passwordless login * Add buildCallbackURL utility function and conditionally spread callbackURI in passwordless login * Rename buildCallbackURL to buildAbsoluteUrl and make passwordlessLoginCallbackURI optional * update unit tests in template-retail-react-app and fix passwordless mode in login page * make authorizePasswordless backward compatible and add unit tests for commerce-sdk-react * Make passwordlessLoginCallbackURI non-optional with empty string default * update changelog * Use endsWith() to match passwordless login landing path and add test for localized paths
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
… via pwa-kit-create-app (#3526)
Signed-off-by: Jinsu Ha <[email protected]>
hajinsuha1
commented
Dec 29, 2025
| callbackURI?: string | ||
| userid: string | ||
| mode?: string | ||
| mode?: 'email' | 'callback' |
Collaborator
Author
There was a problem hiding this comment.
is this a breaking change? Should i keep the type as a general string?
hajinsuha1
changed the title
hajinsuha1
changed the title
* Update getPasswordResetToken to default locale to the one in CommerceApiProvider and pass callback_uri and idp_name only when they are defined * Update resetPassword to default hint to cross_device and pass code_verifier only when it is defined pwa-kit-create-app * Update default.js and /_app-config/index.jsx template to use email mode by default for passwordless login and password reset. * Update password reset to use email mode by default. The mode can now be configured via default.js
12 tasks
…ly" to "Continue" (#3556) * update passwordless and password reset e2e tests to veirfy mode email is used * Update EXTRA_FEATURES_E2E_RETAIL_APP_HOME to support environment variable configuration * Update mobile e2e tests to verify 'email' mode for passwordless login and password reset requests * update "continue securely" to "continue"
hajinsuha1
changed the title
hajinsuha1
changed the title
email mode
Signed-off-by: Jinsu Ha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature allows the mode for passwordless login and password reset to be configured in default.js.
It also changes the default from
callbacktoemailwhich uses the SLAS native email service.This branch contains the following PRs:
emailmode #3547After this PR is merged, to ensure the changes to the E2E tests pass the following PR that updates the
extra-features-e2e-branchwill need to be mergedextra-features-e2e-branchfor E2E tests #3557Types of Changes
Changes
template-retail-react-app
extra-featurese2e testscommerce-sdk-react
getPasswordResetTokento default locale to the one in CommerceApiProvider and pass callback_uri and idp_name only when they are definedresetPasswordto default hint tocross_deviceand pass code_verifier only when it is definedpwa-kit-create-app
default.jsand/_app-config/index.jsxtemplate to use email mode by default for passwordless login and password reset.How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization