Add NPM Token expiry alert to nightly workflow#3582
Merged
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
shethj
commented
Jan 16, 2026
| @@ -1,4 +1,5 @@ | |||
| name: bundlesize | |||
| description: Check bundle size against maximum file size limits | |||
Contributor
Author
There was a problem hiding this comment.
Github actions now requires description as mandatory field for all composite actions.
shethj
changed the title
vmarta
previously approved these changes
Jan 16, 2026
| with: | ||
| payload: | | ||
| { | ||
| "message": "⚠️ NPM Token expiring soon! Only ${{ env.days_left }} days remaining. Please rotate the token using instructions in PWA Kit Release Doc." |
Contributor
There was a problem hiding this comment.
Minor: how about we add a link to this release doc? To make it less searching for others.
adamraya
previously approved these changes
Jan 16, 2026
vcua-mobify
previously approved these changes
Jan 16, 2026
| - name: Check NPM Token Expiry | ||
| if: always() | ||
| run: | | ||
| LAST_ROTATION="${{ secrets.NPM_TOKEN_LAST_ROTATION_DATE }}" |
Contributor
There was a problem hiding this comment.
I assume the instructions for updating this secret are in the doc?
This NPM token corresponds to the one we use for releases, correct?
shethj
dismissed stale reviews from adamraya, vcua-mobify, and vmarta
via
1936bff
vcua-mobify
approved these changes
Jan 17, 2026
vmarta
approved these changes
Jan 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added token expiry script and slack notification to nightly_release workflow.
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization