[Cleanup] Remove unused absoluteUrl util from retail react app#3633
[Cleanup] Remove unused absoluteUrl util from retail react app#3633vcua-mobify merged 3 commits intodevelopfrom
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
| * If not provided, the function will call `getAppOrigin()`. | ||
| * @returns {string} - The fully qualified URL as a string. | ||
| */ | ||
| export const absoluteUrl = (path, appOrigin) => { |
There was a problem hiding this comment.
isn't this is being used in getPasswordlessCallbackUrl?
There was a problem hiding this comment.
nvm, I read it wrong, getPasswordlessCallbackUrl is using isAbsoluteUrl which is diff util func
|
Thanks for working on this |
|
We are releasing another major breaking version for retail-react-app, this is the right time to remove this util. 👍 |
There was a problem hiding this comment.
It looks like we no longer need this mock code since it was only there to support the absoluteUrl tests
There was a problem hiding this comment.
I removed this mock as suggested
| - [Feature] Update passwordless login and password reset to use email mode by default. The mode can now be configured across the login page, auth modal, and checkout page [#3525](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3525) | ||
| - Update "Continue Securely" button text to "Continue" for passwordless login [#3556](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3556) | ||
| - Util function for passwordless callback URI [#3630](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3630) | ||
| - [Cleanup] Remove unused absoluteUrl util from retail react app [#3633](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3633) |
There was a problem hiding this comment.
Should this line be in an new v9.0.0-dev section at the top in the changelog? Also since this removes a public export, might be worth tagging it as [Breaking] instead of [Cleanup] so customers know to watch out for it when upgrading
There was a problem hiding this comment.
Done. I moved everything under 8.5.0-dev and 8.4.0-dev under a new 9.0.0-dev section since our latest release was 8.3.0.
4 participants
Small PR to remove an unused function from the retail-react-app.
Removing
absoluteUrlnow as it is incompatible with current work to add base path prefixes.