Skip to content

[Cleanup] Remove unused absoluteUrl util from retail react app #3633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vcua-mobify merged 3 commits into from
Feb 4, 2026
Merged

[Cleanup] Remove unused absoluteUrl util from retail react app #3633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db4518d
Clean up absoluteUrl
vcua-mobify Feb 3, 2026
33bea2d
Update changelog
vcua-mobify Feb 3, 2026
49a9fbf
Update changelog and remove unused mock
vcua-mobify Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/template-retail-react-app/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
## v8.5.0-dev (Jan 19, 2026)
## v9.0.0-dev (Jan 19, 2026)
- [Feature] One Click Checkout [#3552](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3552)

## v8.4.0-dev (Dec 17, 2025)
- [Feature] Add `fuzzyPathMatching` to reduce computational overhead of route generation at time of application load [#3530](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3530)
- [Bugfix] Fix Passwordless Login landingPath, Reset Password landingPath, and Social Login redirectUri value in config not being used [#3560](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3560)
- [Feature] PWA Integration with OMS
Expand All @@ -12,6 +10,7 @@
- [Feature] Update passwordless login and password reset to use email mode by default. The mode can now be configured across the login page, auth modal, and checkout page [#3525](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3525)
- Update "Continue Securely" button text to "Continue" for passwordless login [#3556](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3556)
- Util function for passwordless callback URI [#3630](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3630)
- [BREAKING] Remove unused absoluteUrl util from retail react app [#3633](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3633)

## v8.3.0 (Dec 17, 2025)
- [Bugfix] Fix Forgot Password link not working from Account Profile password update form [#3493](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3493)
Expand Down
21 changes: 0 additions & 21 deletions packages/template-retail-react-app/app/utils/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,34 +5,13 @@
* For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/BSD-3-Clause
*/

import {getAppOrigin} from '@salesforce/pwa-kit-react-sdk/utils/url'
import {
getLocaleByReference,
getParamsFromPath,
getDefaultSite,
getSiteByReference
} from '@salesforce/retail-react-app/app/utils/site-utils'
import {HOME_HREF, urlPartPositions} from '@salesforce/retail-react-app/app/constants'
import {isAbsoluteURL} from '@salesforce/retail-react-app/app/page-designer/utils'

/**
* Constructs an absolute URL from a given path and an optional application origin.
* TODO: How should this work with base path?
*
* @param {string} path - The relative URL path to be appended to the origin.
* @param {string} [appOrigin] - The optional application origin (e.g., "https://example.com").
* If not provided, the function will call `getAppOrigin()`.
* @returns {string} - The fully qualified URL as a string.
*/
export const absoluteUrl = (path, appOrigin) => {
Copy link
Contributor

@alexvuong alexvuong Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this is being used in getPasswordlessCallbackUrl?

Copy link
Contributor

@alexvuong alexvuong Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, I read it wrong, getPasswordlessCallbackUrl is using isAbsoluteUrl which is diff util func

// If path is not provided or already an absolute URL, return it as-is
if (!path || isAbsoluteURL(path)) {
return path
}

// absoluteUrl is not a react hook so we cannot use the useAppOrigin hook here
return new URL(path, appOrigin || getAppOrigin()).toString()
}

/**
* Modifies a given url by adding/updating query parameters.
Expand Down
38 changes: 0 additions & 38 deletions packages/template-retail-react-app/app/utils/url.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import {
getPathWithLocale,
rebuildPathWithParams,
removeQueryParamsFromPath,
absoluteUrl,
createUrlTemplate,
removeSiteLocaleFromPath,
serverSafeEncode
Expand All @@ -25,13 +24,6 @@ afterEach(() => {
jest.clearAllMocks()
})

jest.mock('@salesforce/pwa-kit-react-sdk/utils/url', () => {
const original = jest.requireActual('@salesforce/pwa-kit-react-sdk/utils/url')
return {
...original,
getAppOrigin: jest.fn(() => 'https://www.example.com')
}
})
jest.mock('./utils', () => {
const original = jest.requireActual('./utils')
return {
Expand Down Expand Up @@ -394,36 +386,6 @@ describe('removeQueryParamsFromPath test', () => {
})
})

describe('absoluteUrl', function () {
test('return undefined when path is not provided', () => {
const url = absoluteUrl()
expect(url).toBeUndefined()
})

test('return expected when path is a relative url', () => {
const url = absoluteUrl('/uk/en/women/dresses')
expect(url).toBe('https://www.example.com/uk/en/women/dresses')
})

test('return expected when path is an absolute url', () => {
const url = absoluteUrl('https://www.example.com/uk/en/women/dresses')
expect(url).toBe('https://www.example.com/uk/en/women/dresses')
})

test('return expected when path is a relative url and appOrigin is provided', () => {
const url = absoluteUrl('uk/en/women/dresses', 'https://www.custom.com')
expect(url).toBe('https://www.custom.com/uk/en/women/dresses')
})

test('return expected when path is an absolute url and appOrigin is provided', () => {
const url = absoluteUrl(
'https://www.example.com/uk/en/women/dresses',
'https://www.should-be-ignored.com'
)
expect(url).toBe('https://www.example.com/uk/en/women/dresses')
})
})

describe('removeSiteLocaleFromPath', function () {
test('return path without site alias and locale', () => {
const pathName = removeSiteLocaleFromPath('/uk/en-GB/account/wishlist')
Expand Down
Loading