Skip to content

@W-20726574 Update template-mrt-reference-app to support testing base path support on MRT #3641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noahadams merged 4 commits into from
Feb 6, 2026
Merged

@W-20726574 Update template-mrt-reference-app to support testing base path support on MRT #3641

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9436909
Add a middleware that consumes the basePath if present
noahadams Feb 5, 2026
b9991a9
update tests to add headers used by logging middleware
noahadams Feb 5, 2026
5ea49de
remove header setting for loggermiddleware, tests pass even with it h…
noahadams Feb 6, 2026
69067f3
format
noahadams Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion packages/template-mrt-reference-app/app/ssr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ const ENVS_TO_EXPOSE = [
'aws_lambda_log_stream_name',
'aws_region',
'bundle_id',
'mrt_env_base_path',
// These "customer" defined environment variables are set by the Manager
// and expected by the MRT smoke test suite
'customer_*',
Expand Down Expand Up @@ -353,6 +354,19 @@ const loggingMiddleware = (req, res, next) => {
return next()
}

const envBasePathMiddleware = (req, res, next) => {
const basePath = process.env.MRT_ENV_BASE_PATH
console.log(`Base path: ${basePath}`)
console.log(`Request path: ${req.url}`)
if (basePath && req.url.startsWith(basePath)) {
req.url = req.path.slice(basePath.length) || '/'
console.log(
`Base path: Rewrote ${basePath} -> Request path: ${req.originalUrl} -> New path: ${req.url}`
)
}
return next()
}

const options = {
// The build directory (an absolute path)
buildDir: path.resolve(process.cwd(), 'build'),
Expand Down Expand Up @@ -387,7 +401,8 @@ const {handler, app, server} = runtime.createHandler(options, (app) => {

// Add middleware to log request and response headers
app.use(loggingMiddleware)

// Add a middleware to consume the base path from the request path if one is set
app.use(envBasePathMiddleware)
// Configure routes
app.all('/exception', exception)
app.get('/tls', tlsVersionTest)
Expand Down
73 changes: 54 additions & 19 deletions packages/template-mrt-reference-app/app/ssr.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ const {
const {mockClient} = require('aws-sdk-client-mock')
const {ServiceException} = require('@smithy/smithy-client')

const standardHeaders = {
'x-correlation-id': 'test-correlation-id',
'x-apigateway-event': 'test-apigateway-event'
}
class AccessDenied extends ServiceException {
constructor(options) {
super({...options, name: 'AccessDenied'})
Expand All @@ -28,6 +32,27 @@ describe('server', () => {
const lambdaMock = mockClient(LambdaClient)
const s3Mock = mockClient(S3Client)
const logsMock = mockClient(CloudWatchLogsClient)
const pathsToCheck = [
['/', 200, 'application/json; charset=utf-8'],
['/tls', 200, 'application/json; charset=utf-8'],
['/exception', 500, 'text/html; charset=utf-8'],
['/cache', 200, 'application/json; charset=utf-8'],
['/cookie', 200, 'application/json; charset=utf-8'],
['/set-response-headers', 200, 'application/json; charset=utf-8'],
['/isolation', 200, 'application/json; charset=utf-8'],
['/memtest', 200, 'application/json; charset=utf-8'],
['/streaming-large', 200, 'application/json; charset=utf-8']
]
const pathsToCheckWithBasePath = (basePath) => {
return pathsToCheck.map(
(pathStatusContentType) => [
basePath + pathStatusContentType[0],
pathStatusContentType[1],
pathStatusContentType[2]
]
)
}

beforeEach(() => {
originalEnv = process.env
process.env = Object.assign({}, process.env, {
Expand All @@ -53,50 +78,60 @@ describe('server', () => {
server.close()
jest.restoreAllMocks()
})
test.each([
['/', 200, 'application/json; charset=utf-8'],
['/tls', 200, 'application/json; charset=utf-8'],
['/exception', 500, 'text/html; charset=utf-8'],
['/cache', 200, 'application/json; charset=utf-8'],
['/cookie', 200, 'application/json; charset=utf-8'],
['/set-response-headers', 200, 'application/json; charset=utf-8'],
['/isolation', 200, 'application/json; charset=utf-8'],
['/memtest', 200, 'application/json; charset=utf-8'],
['/streaming-large', 200, 'application/json; charset=utf-8']
])('Path %p should render correctly', (path, expectedStatus, expectedContentType) => {
test.each(pathsToCheck)('Path %p should render correctly', (path, expectedStatus, expectedContentType) => {
return request(app)
.get(path)
.expect(expectedStatus)
.expect('Content-Type', expectedContentType)
})

test.each(pathsToCheckWithBasePath('/test-base-path'))('Path %p should render correctly', (path, expectedStatus, expectedContentType) => {
process.env.MRT_ENV_BASE_PATH = '/test-base-path'
return request(app)
.get(path)
.set(standardHeaders)
.expect(expectedStatus)
.expect('Content-Type', expectedContentType)
})

test('Path "/cache" has Cache-Control set', () => {
return request(app).get('/cache').expect('Cache-Control', 's-maxage=60')
return request(app)
.get('/cache')
.set(standardHeaders)
.expect('Cache-Control', 's-maxage=60')
})

test('Path "/cache/:duration" has Cache-Control set correctly', () => {
return request(app).get('/cache/123').expect('Cache-Control', 's-maxage=123')
return request(app)
.get('/cache/123')
.set(standardHeaders)
.expect('Cache-Control', 's-maxage=123')
})

test('All responses have Server header set to "mrt ref app"', () => {
return request(app).get('/').expect('Server', 'mrt ref app')
return request(app).get('/').set(standardHeaders).expect('Server', 'mrt ref app')
})

test('Path "/headers" echoes request headers', async () => {
const response = await request(app).get('/headers').set('Random-Header', 'random')
const response = await request(app)
.get('/headers')
.set(standardHeaders)
.set('Random-Header', 'random')

expect(response.body.headers['random-header']).toBe('random')
})

test('Path "/cookie" sets cookie', () => {
return request(app)
.get('/cookie?name=test-cookie&value=test-value')
.set(standardHeaders)
.expect('set-cookie', 'test-cookie=test-value; Path=/')
})

test('Path "/set-response-headers" sets response header', () => {
return request(app)
.get('/set-response-headers?header1=value1&header2=test-value')
.set(standardHeaders)
.expect('header1', 'value1')
.expect('header2', 'test-value')
})
Expand All @@ -107,7 +142,7 @@ describe('server', () => {
s3Mock.on(GetObjectCommand).rejects(new AccessDenied())
logsMock.on(CreateLogStreamCommand).rejects(new AccessDeniedException())
const params = `FunctionName=name&Bucket=bucket&Key=key&logGroupName=lgName`
const response = await request(app).get(`/isolation?${params}`)
const response = await request(app).get(`/isolation?${params}`).set(standardHeaders)
expect(response.body.origin).toBe(true)
expect(response.body.storage).toBe(true)
expect(response.body.logs).toBe(true)
Expand All @@ -119,7 +154,7 @@ describe('server', () => {
s3Mock.on(GetObjectCommand).resolves()
logsMock.on(CreateLogStreamCommand).resolves()
const params = `FunctionName=name&Bucket=bucket&Key=key&logGroupName=lgName`
const response = await request(app).get(`/isolation?${params}`)
const response = await request(app).get(`/isolation?${params}`).set(standardHeaders)
expect(response.body.origin).toBe(false)
expect(response.body.storage).toBe(false)
expect(response.body.logs).toBe(false)
Expand All @@ -133,14 +168,14 @@ describe('server', () => {
})

test('Path "/ssr-shared" serves the example.json file', async () => {
const response = await request(app).get('/ssr-shared')
const response = await request(app).get('/ssr-shared').set(standardHeaders)
expect(response.body.message).toBe(
'This file is used in the E2E tests to verify that correct header values are set.'
)
})

test('Path "/streaming-large" returns streaming: false', async () => {
const response = await request(app).get('/streaming-large')
const response = await request(app).get('/streaming-large').set(standardHeaders)
expect(response.status).toBe(200)
expect(response.body).toEqual({streaming: false})
})
Expand Down
Loading