Skip to content

@W-20726574 Update template-mrt-reference-app to support testing base path support on MRT#3641

Merged
noahadams merged 4 commits intomrt-feature-branch-mrt-ref-app-aws-serverless-expressfrom
mrt-feature-branch-support-basepath-in-aws-serverless-express-refapp
Feb 6, 2026
Merged

@W-20726574 Update template-mrt-reference-app to support testing base path support on MRT#3641
noahadams merged 4 commits intomrt-feature-branch-mrt-ref-app-aws-serverless-expressfrom
mrt-feature-branch-support-basepath-in-aws-serverless-express-refapp

Conversation

@noahadams
Copy link
Collaborator

@noahadams noahadams commented Feb 5, 2026

Description

  • in template-mrt-reference-app, adds a middleware that looks for the environemnt variable MRT_ENV_BASE_PATH, and if it is present, rewrites request paths that start with the value to not have it
  • adds relevant test cases

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • in template-mrt-reference-app, adds a middleware that looks for the environemnt variable MRT_ENV_BASE_PATH, and if it is present, rewrites request paths that start with the value to not have it
  • adds relevant test cases, and updates ssr.test.js to set headers required by the logging middleware

How to Test-Drive This PR

  • checkout branch, and with Node.js v22.x installed and active, from checkout root run
  • npm ci
  • cd packages/template-mrt-reference-app
  • npm run test

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@noahadams noahadams requested a review from a team as a code owner February 5, 2026 22:36
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Feb 5, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@noahadams noahadams requested a review from vcua-mobify February 5, 2026 22:36
@noahadams noahadams changed the title Update template-mrt-reference-app to support testing base path support on MRT @W-20726574 Update template-mrt-reference-app to support testing base path support on MRT Feb 5, 2026
@noahadams noahadams force-pushed the mrt-feature-branch-support-basepath-in-aws-serverless-express-refapp branch from ce4bfbf to b9991a9 Compare February 5, 2026 23:18
noahadams added a commit that referenced this pull request Feb 6, 2026
Copy link
Contributor

@vcua-mobify vcua-mobify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The npm 11 CI jobs are failing so it looks like you might need to do a package-lock update. But that doesn't seem related to the actual changes in this PR and this PR is going into a feature branch not develop so +1.

We'll want to ensure the npm 11 CI passes once we're ready to merge into develop.

@noahadams noahadams merged commit 634434d into mrt-feature-branch-mrt-ref-app-aws-serverless-express Feb 6, 2026
65 of 74 checks passed
@noahadams noahadams deleted the mrt-feature-branch-support-basepath-in-aws-serverless-express-refapp branch February 6, 2026 01:35
unandyala pushed a commit that referenced this pull request Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants