Skip to content

[Node 24][V3] Migrate Deprecated Node URL APIs to WHATWG Standard (@W-20777230@) #3652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamraya merged 12 commits into from
Feb 11, 2026
Merged

[Node 24][V3] Migrate Deprecated Node URL APIs to WHATWG Standard (@W-20777230@) #3652

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
acd5ce0
Migrate to WHATWG URL constructor
adamraya Feb 10, 2026
17847f3
lint
adamraya Feb 10, 2026
9f79db6
clean up
adamraya Feb 10, 2026
535648c
Merge branch 'develop' into W-20777230-node-24-v3-url
adamraya Feb 10, 2026
90a20c8
Merge branch 'develop' into W-20777230-node-24-v3-url
adamraya Feb 10, 2026
1c2fda6
Update CHANGELOG.md
adamraya Feb 10, 2026
a349b66
Update changelogs
adamraya Feb 10, 2026
a878f25
Update changelog and lock files
adamraya Feb 10, 2026
2091b73
Update package-lock.json
adamraya Feb 11, 2026
56c1656
Clear verdaccio npm cache
adamraya Feb 11, 2026
14340c9
Update changelogs
adamraya Feb 11, 2026
cc4796c
Merge branch 'develop' into W-20777230-node-24-v3-url
adamraya Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [18, 20, 22]
npm: [8, 9, 10, 11]
node: [18, 20, 22, 24]
npm: [9, 10, 11]
exclude: # node 18 with npm 11 are not compatible
- node: 18
npm: 11
Expand All @@ -62,7 +62,7 @@ jobs:
# The "default" npm is the one that ships with a given version of node.
# For more: https://nodejs.org/en/download/releases/
# (We also use this env var for making sure a step runs once for the current node version)
IS_DEFAULT_NPM: ${{ (matrix.node == 18 && matrix.npm == 10) || (matrix.node == 20 && matrix.npm == 10) || (matrix.node == 22 && matrix.npm == 10) }}
IS_DEFAULT_NPM: ${{ (matrix.node == 18 && matrix.npm == 10) || (matrix.node == 20 && matrix.npm == 10) || (matrix.node == 22 && matrix.npm == 10) || (matrix.node == 24 && matrix.npm == 11) }}
# The current recommended version for Managed Runtime:
# https://developer.salesforce.com/docs/commerce/pwa-kit-managed-runtime/guide/upgrade-node-version.html
IS_MRT_NODE: ${{ matrix.node == 22 && matrix.npm == 10 }}
Expand Down Expand Up @@ -157,8 +157,8 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [18, 20, 22]
npm: [8, 9, 10, 11]
node: [18, 20, 22, 24]
npm: [9, 10, 11]
exclude: # node 18 with npm 11 is not compatible
- node: 18
npm: 11
Expand All @@ -167,8 +167,7 @@ jobs:
# The "default" npm is the one that ships with a given version of node.
# For more: https://nodejs.org/en/download/releases/
# (We also use this env var for making sure a step runs once for the current node version)
# Note: For node 18, the default was npm 9 until v18.19.0, when it became npm 10
IS_DEFAULT_NPM: ${{ (matrix.node == 18 && matrix.npm == 10) || (matrix.node == 20 && matrix.npm == 10) || (matrix.node == 22 && matrix.npm == 10) }}
IS_DEFAULT_NPM: ${{ (matrix.node == 18 && matrix.npm == 10) || (matrix.node == 20 && matrix.npm == 10) || (matrix.node == 22 && matrix.npm == 10) || (matrix.node == 24 && matrix.npm == 11) }}
# The current recommended version for Managed Runtime:
# https://developer.salesforce.com/docs/commerce/pwa-kit-managed-runtime/guide/upgrade-node-version.html
IS_MRT_NODE: ${{ matrix.node == 22 && matrix.npm == 10 }}
Expand Down
35 changes: 10 additions & 25 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@
"syncpack": "^10.1.0"
},
"engines": {
"node": "^16.11.0 || ^18.0.0 || ^20.0.0 || ^22.0.0",
"npm": "^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0"
"node": "^18.0.0 || ^20.0.0 || ^22.0.0 || ^24.0.0",
"npm": "^9.0.0 || ^10.0.0 || ^11.0.0"
},
"dependencies": {
"@aws-sdk/client-cloudwatch": "^3.962.0",
Expand Down
7 changes: 5 additions & 2 deletions packages/commerce-sdk-react/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/commerce-sdk-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@
"react-router-dom": "^5.3.4"
},
"engines": {
"node": "^16.11.0 || ^18.0.0 || ^20.0.0 || ^22.0.0",
"npm": "^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0"
"node": "^18.0.0 || ^20.0.0 || ^22.0.0 || ^24.0.0",
"npm": "^9.0.0 || ^10.0.0 || ^11.0.0"
},
"publishConfig": {
"directory": "dist"
Expand Down
Loading
Loading