[Node 24][V3] Migrate Deprecated Node URL APIs to WHATWG Standard (@W-20777230@)#3652
Merged
[Node 24][V3] Migrate Deprecated Node URL APIs to WHATWG Standard (@W-20777230@)#3652
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
bendvc
previously approved these changes
Feb 10, 2026
alexvuong
reviewed
Feb 10, 2026
alexvuong
previously approved these changes
Feb 10, 2026
Contributor
alexvuong
left a comment
There was a problem hiding this comment.
Small comment, non blocker. LGTM
alexvuong
approved these changes
Feb 11, 2026
bendvc
approved these changes
Feb 11, 2026
kevinxh
added a commit
that referenced
this pull request
Feb 13, 2026
The merge conflict resolution used --theirs (release branch) for package-lock files, which lost develop-only changes like Node 24 engine support from #3652. Restore lock files from develop and re-run npm install to pick up version bumps. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates all usages of Node.js legacy URL APIs
url.parse()andurl.format()to the modern WHATWGURLstandard to eliminate deprecation warnings when running on Node.js 24.The PR also removes npm 8 , since npm 8 shipped as the default package manager with Node 16 and we don't support Node 16 in PWA Kit v3, since is no longer supported by MRT, from engine constraints and CI matrix, and adds Node 24 support.
Types of Changes
Changes
URL.parse(req.url)withnew URL(req.url, 'http://localhost')andURL.format(parsed)with WHATWGURLconstructor.engines.node to include ^24.0.0 across allpackage.json` filesHow to Test-Drive This PR
cd packages/pwa-kit-runtime && npm testurl.parse/url.formatdeprecation warnings appear in the consoleChecklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization