fix: Responses API cancel requests can still end as completed#789
Closed
sam-saffron-jarvis wants to merge 1 commit into
Closed
fix: Responses API cancel requests can still end as completed#789sam-saffron-jarvis wants to merge 1 commit into
sam-saffron-jarvis wants to merge 1 commit into
Conversation
Owner
This was referenced Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
responseRun.completeto give pending cancellation precedence over completion.cancelled, emitsresponse.cancelled, and strips completion-only usage fields from the terminal response payload.cancelRun()wins just beforecomplete()finalizes the run.Why this is high-value
This fixes a user-visible correctness bug in the Responses API: a client could successfully POST
/canceland still receiveresponse.completedif generation had already finished but the final completion transition had not run yet. That made cancellation flaky on long-running web/API sessions, left the run snapshot looking successful, and could mislead reconnecting SSE clients.Validation
gofmt -w cmd/serve_response_runs.go cmd/serve_response_runs_test.gogo build ./...go test ./...TestResponseRunCompleteHonorsPendingCancellationto verify cancellation wins over completion.git diff --check