fix: Job cancellation can be overwritten by a later successful/failed finish#790
Closed
sam-saffron-jarvis wants to merge 1 commit into
Closed
fix: Job cancellation can be overwritten by a later successful/failed finish#790sam-saffron-jarvis wants to merge 1 commit into
sam-saffron-jarvis wants to merge 1 commit into
Conversation
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
finishRunperform a guarded terminal-state update instead of blindly overwriting whatever status is already injob_runs_v2.cancel_requested,finishRunnow persists it ascancelledand keeps cancellation authoritative even if the worker later reportssucceeded,failed, ortimed_out.Why this is high-value
Cancellation is a real user-facing control path. Before this change, there was a race where
CancelRuncould acknowledge cancellation in the DB, but a slightly later worker finish would overwrite that state back to success/failure/timeout. That could:This fix makes cancellation authoritative at the persistence boundary, which is the smallest safe place to close the race.
Validation
TestJobsV2FinishRunDoesNotOverrideCancelRequestedgofmt -w cmd/serve_jobs_v2.go cmd/serve_jobs_v2_test.gogo build ./...go test ./...git diff --check