read recommended repositories by it types - #2049
Conversation
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Before selecting filter_type in read(), clear any existing filter selections to avoid carrying over stale UI state across calls.
- The locator for search_by_filter_type uses an index-based bs-select-2; consider switching to a more robust selector (e.g. data attributes or a unique class) to reduce fragility if the DOM order changes.
- With multiple optional search parameters (entity_name, category, recommended_repo, filter_type), you might simplify the signature by accepting a single options object or dict for better scalability.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Before selecting filter_type in read(), clear any existing filter selections to avoid carrying over stale UI state across calls.
- The locator for search_by_filter_type uses an index-based bs-select-2; consider switching to a more robust selector (e.g. data attributes or a unique class) to reduce fragility if the DOM order changes.
- With multiple optional search parameters (entity_name, category, recommended_repo, filter_type), you might simplify the signature by accepting a single options object or dict for better scalability.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
@vijaysawant, I thought you had confirmed via slack that |
Hey @LadislavVasina1, The solution you suggested worked (passing list of strings). But as per nature of robottelo test case, passing single value to |
|
@vijaysawant Can you link the test you are talking about please? |
31716c6 to
034abd1
Compare
Please see description, robottelo PR 19676 is open. |
sambible
left a comment
There was a problem hiding this comment.
ACK Pending explanation of my comment. I'm assuming it has something to do with loading/navigation, but I'm not sure.
(cherry picked from commit d4bd8c1)
(cherry picked from commit d4bd8c1)
Problem Statement
No support presented for
recommended kickstart repositoriesin airgun entities & in views.Solution
Update
RedHatRepositoryEntityread method andRedHatRepositoriesViewwith required changes.Related robottelo PR
SatelliteQE/robottelo#19676