Skip to content

read recommended repositories by it types - #2049

Merged
LadislavVasina1 merged 1 commit into
SatelliteQE:masterfrom
vijaysawant:added_support_for_recommended_kickstart_repos
Sep 25, 2025
Merged

read recommended repositories by it types#2049
LadislavVasina1 merged 1 commit into
SatelliteQE:masterfrom
vijaysawant:added_support_for_recommended_kickstart_repos

Conversation

@vijaysawant

Copy link
Copy Markdown
Contributor

Problem Statement
No support presented for recommended kickstart repositories in airgun entities & in views.

Solution
Update RedHatRepositoryEntity read method and RedHatRepositoriesView with required changes.

Related robottelo PR
SatelliteQE/robottelo#19676

@vijaysawant vijaysawant added Auto_Cherry_Picked GHA has automatically cherrypicked this PR AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing 6.17.z 6.18.z labels Sep 23, 2025

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Before selecting filter_type in read(), clear any existing filter selections to avoid carrying over stale UI state across calls.
  • The locator for search_by_filter_type uses an index-based bs-select-2; consider switching to a more robust selector (e.g. data attributes or a unique class) to reduce fragility if the DOM order changes.
  • With multiple optional search parameters (entity_name, category, recommended_repo, filter_type), you might simplify the signature by accepting a single options object or dict for better scalability.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Before selecting filter_type in read(), clear any existing filter selections to avoid carrying over stale UI state across calls.
- The locator for search_by_filter_type uses an index-based bs-select-2; consider switching to a more robust selector (e.g. data attributes or a unique class) to reduce fragility if the DOM order changes.
- With multiple optional search parameters (entity_name, category, recommended_repo, filter_type), you might simplify the signature by accepting a single options object or dict for better scalability.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@vijaysawant
vijaysawant marked this pull request as draft September 23, 2025 16:17
@vijaysawant
vijaysawant marked this pull request as ready for review September 23, 2025 17:17
@LadislavVasina1

Copy link
Copy Markdown
Contributor

@vijaysawant, I thought you had confirmed via slack that view.search_by_filter_type.fill(['string1', 'string2']) worked for selecting RPM, Kickstart, etc.
Is it not true already?

@LadislavVasina1
LadislavVasina1 self-requested a review September 24, 2025 06:24
@vijaysawant

Copy link
Copy Markdown
Contributor Author

@vijaysawant, I thought you had confirmed via slack that view.search_by_filter_type.fill(['string1', 'string2']) worked for selecting RPM, Kickstart, etc. Is it not true already?

Hey @LadislavVasina1, The solution you suggested worked (passing list of strings). But as per nature of robottelo test case, passing single value to view.search_by_filter_type.fill() important as we are using parameterisation. That is the reason I didn't use list here.

@LadislavVasina1

Copy link
Copy Markdown
Contributor

@vijaysawant Can you link the test you are talking about please?

@vijaysawant
vijaysawant force-pushed the added_support_for_recommended_kickstart_repos branch from 31716c6 to 034abd1 Compare September 24, 2025 09:09
@vijaysawant

Copy link
Copy Markdown
Contributor Author

@vijaysawant Can you link the test you are talking about please?

Please see description, robottelo PR 19676 is open.

@LadislavVasina1 LadislavVasina1 added CherryPick PR needs CherryPick to previous branches Stream and removed Auto_Cherry_Picked GHA has automatically cherrypicked this PR labels Sep 24, 2025

@sambible sambible left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK Pending explanation of my comment. I'm assuming it has something to do with loading/navigation, but I'm not sure.

Comment thread airgun/entities/redhat_repository.py
@LadislavVasina1
LadislavVasina1 merged commit d4bd8c1 into SatelliteQE:master Sep 25, 2025
11 of 12 checks passed
github-actions Bot pushed a commit that referenced this pull request Sep 25, 2025
github-actions Bot pushed a commit that referenced this pull request Sep 25, 2025
vsedmik pushed a commit that referenced this pull request Oct 31, 2025
(cherry picked from commit d4bd8c1)

Co-authored-by: vijay sawant <visawant@redhat.com>
sambible pushed a commit that referenced this pull request Oct 31, 2025
(cherry picked from commit d4bd8c1)

Co-authored-by: vijay sawant <visawant@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.17.z 6.18.z AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing CherryPick PR needs CherryPick to previous branches Stream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants