Adjust toast list matchers - #2490
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The updated "Locator example" in the docstring now only selects the
<ul>node, whereas previously it showed a full path down to the<div>; consider updating it to reflect the full effective locator (or at least align withMSG_LOCATOR) so the example remains practically useful.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The updated "Locator example" in the docstring now only selects the `<ul>` node, whereas previously it showed a full path down to the `<div>`; consider updating it to reflect the full effective locator (or at least align with `MSG_LOCATOR`) so the example remains practically useful.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
trigger: test-robottelo |
Contributor
|
PRT Result |
Contributor
Author
|
That one test failure seems to be unrelated. |
lhellebr
approved these changes
Jul 29, 2026
LadislavVasina1
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To account for changes in https://github.com/theforeman/foreman/pull/10968/changes#diff-20a024d276bc8814e6b0ac071d829a9b1c0f47b636c6bcaa835ed80292b04686R59 which caused the original selector to no longer match