Skip to content

Adjust toast list matchers - #2490

Merged
LadislavVasina1 merged 1 commit into
SatelliteQE:masterfrom
adamruzicka:toast
Jul 31, 2026
Merged

Adjust toast list matchers#2490
LadislavVasina1 merged 1 commit into
SatelliteQE:masterfrom
adamruzicka:toast

Conversation

@adamruzicka

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The updated "Locator example" in the docstring now only selects the <ul> node, whereas previously it showed a full path down to the <div>; consider updating it to reflect the full effective locator (or at least align with MSG_LOCATOR) so the example remains practically useful.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The updated "Locator example" in the docstring now only selects the `<ul>` node, whereas previously it showed a full path down to the `<div>`; consider updating it to reflect the full effective locator (or at least align with `MSG_LOCATOR`) so the example remains practically useful.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@adamruzicka adamruzicka added locator Locator changes No-CherryPick PR doesnt need CherryPick to previous branches Stream labels Jul 28, 2026
@LadislavVasina1

Copy link
Copy Markdown
Contributor

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py

@Satellite-QE

Copy link
Copy Markdown
Contributor

PRT Result

Build Number: 876
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_host.py --external-logging
Test Result : = 1 failed, 97 passed, 1 deselected, 1416 warnings, 1 error in 29743.76s (8:15:43) =

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jul 28, 2026
@adamruzicka

Copy link
Copy Markdown
Contributor Author

That one test failure seems to be unrelated.

@pondrejk pondrejk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LadislavVasina1
LadislavVasina1 merged commit be986c0 into SatelliteQE:master Jul 31, 2026
10 of 11 checks passed
@adamruzicka
adamruzicka deleted the toast branch July 31, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

locator Locator changes No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR Stream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants