Modifications in CLI and UI Libvirt CR to resolve key error

[nacoool]

Problem Statement

The test test_positive_provision_end_to_end is failing intermittently with a KeyError during execution of the lambda function used in the wait_for call. This happens when the status or build-status keys are temporarily unavailable in the Satellite API response, causing the test to break before the timeout is reached.

Solution

Updated the lambda function inside the wait_for call to safely handle missing keys and potential transient exceptions by using .get() methods and handle_exception=True.
This ensures the polling logic continues gracefully until the host build is complete, thereby preventing continue flow of code even after the timeout happens.

Restarting DHCP as dhcpd service does not recover from (Network is down) state on its own.
Removing UEFI and secure-boot for RHEL 7 because RHEL 7 is not supported with UEFI on VMware and libvirt hypervisors. mentioned in SAT-41340 for CLI testcase.

Adding BIOS back as it is working while Restarting of DHCPD

Added Restart of DHCPD for booting of RHEL 8 host on libvirt.

Related Issues

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[nacoool]

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_libvirt.py -k "test_positive_provision_end_to_end"

[amolpati30]

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_libvirt.py -k "test_positive_provision_end_to_end"
provisioning: true

[shubhamsg199]

trigger: test-robottelo
pytest: tests/foreman/ --component ComputeResources-libvirt
provisioning: true

[Satellite-QE]

PRT Result

Build Number: 13426
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ --component ComputeResources-libvirt --external-logging --include-onprem-provisioning
Test Result : == 69 passed, 5739 deselected, 241 warnings, 10 errors in 3352.86s (0:55:52) ===

[Gauravtalreja1]

trigger: test-robottelo
pytest: tests/foreman/ --component ComputeResources-libvirt
provisioning: true

[Satellite-QE]

PRT Result

Build Number: 13433
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ --component ComputeResources-libvirt --external-logging --include-onprem-provisioning
Test Result : == 3 failed, 76 passed, 5739 deselected, 881 warnings in 15210.97s (4:13:30) ===

[stejskalleos]

Tests are failing, @amolpati30 any updates?

[nacoool]

@stejskalleos The test case which is rectified is tests/foreman/cli/test_computeresource_libvirt.py::test_positive_provision_end_to_end
which is failing intermittently during execution of the lambda function used in the wait_for call.
It returns a boolean:

• True → when build-status is not "Pending installation" or key missing
• False → when it is "Pending installation"

Thus

We have updated the lambda function inside the wait_for call to safely handle missing keys so.
It returns a boolean:

• True → when build-status is not "Pending installation"
• False → when it is "Pending installation" or key missing.

In the previous PRT result, Build Number: 13433
The testcase is correctly waiting for status, and is giving timeout error.

[nacoool]

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_libvirt.py -k "test_positive_provision_end_to_end"
provisioning: true

[nacoool]

trigger: test-robottelo
pytest: tests/foreman/ --component ComputeResources-libvirt
provisioning: true

[Satellite-QE]

PRT Result

Build Number: 13592
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ --component ComputeResources-libvirt --external-logging --include-onprem-provisioning
Test Result : = 3 failed, 76 passed, 5737 deselected, 858 warnings, 1 error in 18868.18s (5:14:28) =

[nacoool]

trigger: test-robottelo
pytest: tests/foreman/ --component ComputeResources-libvirt
provisioning: true

[nacoool]

trigger: test-robottelo
pytest: tests/foreman/ --component ComputeResources-libvirt
provisioning: true

[evgeni]

the diff looks good to me

@Gauravtalreja1 wdyt?

[Satellite-QE]

PRT Result

Build Number: 14185
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ --component ComputeResources-libvirt --external-logging --include-onprem-provisioning
Test Result : = 4 failed, 86 passed, 5754 deselected, 1615 warnings, 10 errors in 16712.14s (4:38:32) =

[Satellite-QE]

PRT Result

Build Number: 14188
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ --component ComputeResources-libvirt --external-logging --include-onprem-provisioning
Test Result : = 4 failed, 92 passed, 4 skipped, 5754 deselected, 1583 warnings in 21414.66s (5:56:54) =

[nacoool]

Required tests are passed.

[nacoool]

trigger: test-robottelo
pytest: tests/foreman/ --component ComputeResources-libvirt
provisioning: true
airgun : 2304

[Satellite-QE]

PRT Result

Build Number: 14211
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ --component ComputeResources-libvirt --external-logging --include-onprem-provisioning
Test Result : = 4 failed, 92 passed, 4 skipped, 5755 deselected, 1602 warnings in 20698.77s (5:44:58) =

[nacoool]

Required tests are passed.

[Gauravtalreja1]

ACK, Great job @nacoool 🚀