CCV auto-publish on child CV minor version publish

[vijaysawant]

Problem Statement

When publishing a minor version of a content view, parent composite content views no longer respect the --propagate-all-composites flag.
https://issues.redhat.com/browse/SAT-34620

Solution

Newly added test case will verify the incremental update on the CV with the --propagate-all-composites flag

Related Issues

N/A

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py -k 'test_ccv_no_double_update_on_incremental_with_propagate_all_composites'

Summary by Sourcery

Tests:

• Add API test validating CCV behavior on incremental updates with --propagate-all-composites and on subsequent major CV publication, covering SAT-34620.

[sourcery-ai]

Reviewer's Guide

Adds a new API test that verifies composite content views with auto-publish and 'Always update to latest' components do not create an extra major version when a child content view undergoes an incremental minor version update with --propagate-all-composites, while still auto-publishing on a later major version publish.

File-Level Changes

Change	Details	Files
Add regression test for SAT-34620 covering CCV behavior on incremental minor updates with propagate-all-composites and subsequent major version publish.	Create a new test that provisions a repo with missing errata, syncs it, and captures an erratum ID for use in incremental updates. Define a content view (CV) with the repo, publish version 1.0, and assert the created version is 1.0. Create a composite content view (CCV) with the CV version as a component, enable auto-publish and set the component to Always update to latest, publish CCV 1.0, and assert the initial CCV version list contains only 1.0. Perform a content view version incremental_update with propagate_all_composites=True and specific errata IDs, targeting the Library environment. Re-read CV and CCV, collect and sort their version strings, and assert that only versions 1.0 and 1.1 exist for both CV and CCV, failing with an explanatory message if a CCV 2.0 was created. Add an extra repository, sync it, attach it to the CV, update the CV, and publish again to create CV 2.0. Re-read the CCV versions after the major publish and assert that 2.0 exists, verifying auto-publish behavior for major version updates.	tests/foreman/api/test_contentview.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[vijaysawant]

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py -k 'test_ccv_no_double_update_on_incremental_with_propagate_all_composites'

[Satellite-QE]

PRT Result

Build Number: 14370
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_contentview.py -k test_ccv_no_double_update_on_incremental_with_propagate_all_composites --external-logging
Test Result : =========== 1 passed, 98 deselected, 6 warnings in 897.77s (0:14:57) ===========

[qcjames53]

Thanks for the Robottelo PR, Vijay! This is looking pretty good to me. I just had a few tweaks.

[vsedmik]

Overall looks good to me, added a few comments to address.

[vsedmik]

I believe we really should add wait_for_tasks before L2156 (cvv = cvv.read()).

Without that we are expecting that the code execution between L2150 and 2156 (cv.publish() to ccv.read()) will be slower than the asynchronous auto-publish task, which may not happen when the instance is busy or the repo size increases and may cause flakiness.

[vijaysawant]

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py -k 'test_ccv_no_double_update_on_incremental_with_propagate_all_composites'

[Satellite-QE]

PRT Result

Build Number: 14426
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_contentview.py -k test_ccv_no_double_update_on_incremental_with_propagate_all_composites --external-logging
Test Result : =========== 1 passed, 98 deselected, 6 warnings in 912.57s (0:15:12) ===========

[vsedmik]

Looks good to me

[qcjames53]

This looks really good. I have to suggest one tweak to the comments. Sorry 😬

[vijaysawant]

Just updated the step section with suggested changes.

[qcjames53]

This looks great, thank you :)