set the logout redirect setting within the test body by pondrejk · Pull Request #20824 · SatelliteQE/robottelo

pondrejk · 2026-02-19T09:37:14Z

Problem Statement

continuation from #20718, it seems that other test tend to override the global setting for the altered test, so it passes when run in isolation but not in batch session in with other tests -- edit: the issue was actually in fixture precedence

Solution

setting is now changed in test body

Related Issues

Summary by Sourcery

Tests:

Mark the LDAP logout redirect test to run in a single thread to avoid concurrency-related interference.

sourcery-ai · 2026-02-19T09:37:20Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the RH-SSO single sign-on LDAP test to manage the logout redirect setting locally within the test, and removes the indirect parametrization that previously modified this setting globally.

File-Level Changes

Change	Details	Files
Refactor the RH-SSO SSO test to update and restore the login_delegation_logout_url setting within the test instead of using a global, indirect parametrized fixture.	Remove the pytest parametrization that indirectly updated the login_delegation_logout_url setting for the test. Adjust the test_single_sign_on_using_rhsso signature to stop depending on the setting_update fixture. Within the test body, fetch the login_delegation_logout_url setting object from the Satellite API and capture its current value. Set login_delegation_logout_url to LOGIN_DELEGATION_LOGOUT_URL before performing the logout flow and asserting the redirect URL. Restore the setting to its original value at the end of the test to avoid side effects on other tests.	`tests/foreman/destructive/test_ldap_authentication.py`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey - I've left some high level feedback:

Consider adding a brief code comment near the @pytest.mark.run_in_one_thread marker explaining why this particular test must be serialized, so future maintainers understand the constraint and are less likely to remove it inadvertently.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider adding a brief code comment near the `@pytest.mark.run_in_one_thread` marker explaining why this particular test must be serialized, so future maintainers understand the constraint and are less likely to remove it inadvertently.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

pondrejk · 2026-02-19T09:40:39Z

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldap_authentication.py -n6

pondrejk · 2026-02-23T08:30:59Z

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldap_authentication.py -n6

pondrejk · 2026-02-23T14:05:52Z

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldap_authentication.py -k test_single_sign_on_using_rhsso

Satellite-QE · 2026-02-23T14:59:26Z

PRT Result

Build Number: 14412
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_ldap_authentication.py -k test_single_sign_on_using_rhsso --external-logging
Test Result : ========== 1 failed, 28 deselected, 14 warnings in 2659.71s (0:44:19) ==========

pondrejk · 2026-02-25T14:41:22Z

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldap_authentication.py -k test_single_sign_on_using_rhsso

Satellite-QE · 2026-02-25T15:26:30Z

PRT Result

Build Number: 14474
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_ldap_authentication.py -k test_single_sign_on_using_rhsso --external-logging
Test Result : ========== 1 passed, 28 deselected, 10 warnings in 2163.30s (0:36:03) ==========

sourcery-ai

Hey - I've left some high level feedback:

The manual save/restore of login_delegation_logout_url would be more robust if wrapped in a try/finally block (or context manager) so the setting is restored even when an assertion or navigation error fails the test.
Instead of indexing [0] on module_target_sat.api.Setting().search(...), consider explicitly asserting that exactly one setting is returned or handling the case where no result is found to avoid an opaque index error.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The manual save/restore of `login_delegation_logout_url` would be more robust if wrapped in a `try/finally` block (or context manager) so the setting is restored even when an assertion or navigation error fails the test.
- Instead of indexing `[0]` on `module_target_sat.api.Setting().search(...)`, consider explicitly asserting that exactly one setting is returned or handling the case where no result is found to avoid an opaque index error.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

adamlazik1 · 2026-02-25T15:47:00Z

The manual save/restore of login_delegation_logout_url would be more robust if wrapped in a try/finally block (or context manager) so the setting is restored even when an assertion or navigation error fails the test.

This seems like a valid concern.

adamlazik1

LGTM

(cherry picked from commit c18855a)

* check logout redirection (#20718) (cherry picked from commit 90b1295) * set the logout redirect setting within the test body (#20824) --------- Co-authored-by: Peter Ondrejka <pondrejk@users.noreply.github.com>

pondrejk self-assigned this Feb 19, 2026

pondrejk requested a review from a team as a code owner February 19, 2026 09:37

pondrejk added Stream Introduced in or relating directly to Satellite Stream/Master 6.19.z labels Feb 19, 2026

pondrejk marked this pull request as draft February 19, 2026 09:37

sourcery-ai Bot reviewed Feb 19, 2026

View reviewed changes

pondrejk added the CherryPick PR needs CherryPick to previous branches label Feb 19, 2026

pondrejk marked this pull request as ready for review February 23, 2026 11:56

Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 23, 2026

pondrejk marked this pull request as draft February 23, 2026 15:04

pondrejk force-pushed the logout-one-thr branch from 39e0745 to 4c06ca7 Compare February 25, 2026 14:11

pondrejk changed the title ~~run in one thread for logout redirect~~ set the logout redirect setting within the test body Feb 25, 2026

Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Feb 25, 2026

pondrejk marked this pull request as ready for review February 25, 2026 15:28

sourcery-ai Bot reviewed Feb 25, 2026

View reviewed changes

pondrejk added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Feb 25, 2026

set the logout redirect setting within the test body

0e631a2

pondrejk force-pushed the logout-one-thr branch from 4c06ca7 to 0e631a2 Compare February 25, 2026 15:51

Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 25, 2026

adamlazik1 approved these changes Feb 25, 2026

View reviewed changes

pondrejk merged commit c18855a into SatelliteQE:master Feb 25, 2026
10 checks passed

github-actions Bot pushed a commit that referenced this pull request Feb 25, 2026

set the logout redirect setting within the test body (#20824)

79e5f38

(cherry picked from commit c18855a)

Satellite-QE mentioned this pull request Feb 25, 2026

[6.19.z] set the logout redirect setting within the test body #20874

Merged

rmynar pushed a commit to rmynar/robottelo that referenced this pull request Apr 29, 2026

set the logout redirect setting within the test body (SatelliteQE#20824)

4b0753e

Uh oh!

Conversation

pondrejk commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem Statement

Solution

Related Issues

Summary by Sourcery

Uh oh!

sourcery-ai Bot commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

pondrejk commented Feb 19, 2026

Uh oh!

pondrejk commented Feb 23, 2026

Uh oh!

pondrejk commented Feb 23, 2026

Uh oh!

Satellite-QE commented Feb 23, 2026

Uh oh!

pondrejk commented Feb 25, 2026

Uh oh!

Satellite-QE commented Feb 25, 2026

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

adamlazik1 commented Feb 25, 2026

Uh oh!

adamlazik1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pondrejk commented Feb 19, 2026 •

edited

Loading

sourcery-ai Bot commented Feb 19, 2026 •

edited

Loading