Skip to content

adding blockedby to auth tests - #20837

Merged
pondrejk merged 1 commit into
SatelliteQE:masterfrom
pondrejk:block-auth
Feb 23, 2026
Merged

adding blockedby to auth tests#20837
pondrejk merged 1 commit into
SatelliteQE:masterfrom
pondrejk:block-auth

Conversation

@pondrejk

@pondrejk pondrejk commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

Problem Statement

adding blocked by to automation to not pollute the results until the bug is fixed

Solution

Related Issues

Summary by Sourcery

Tests:

  • Annotate several LDAP authentication tests with a BlockedBy reference (SAT-42705) so they are treated as blocked until the underlying bug is resolved.

@pondrejk pondrejk self-assigned this Feb 23, 2026
@pondrejk
pondrejk requested a review from a team as a code owner February 23, 2026 09:38
@pondrejk pondrejk added CherryPick PR needs CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master 6.19.z labels Feb 23, 2026
@sourcery-ai

sourcery-ai Bot commented Feb 23, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Marks several LDAP authentication UI and destructive tests as blocked by known issue SAT-42705 to keep automation results clean until the bug is resolved.

File-Level Changes

Change Details Files
Annotate LDAP authentication UI tests with a BlockedBy reference to SAT-42705.
  • Add :BlockedBy: SAT-42705 metadata to external roles update test.
  • Add :BlockedBy: SAT-42705 metadata to external roles delete test.
  • Add :BlockedBy: SAT-42705 metadata to admin role with org/location test.
  • Add :BlockedBy: SAT-42705 metadata to group permissions verification test.
tests/foreman/ui/test_ldap_authentication.py
Annotate destructive LDAP authentication test with a BlockedBy reference to SAT-42705.
  • Add :BlockedBy: SAT-42705 metadata to RHS SSO user multiple group permissions test.
tests/foreman/destructive/test_ldap_authentication.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@adamlazik1 adamlazik1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pondrejk
pondrejk merged commit 0f48d29 into SatelliteQE:master Feb 23, 2026
11 checks passed
github-actions Bot pushed a commit that referenced this pull request Feb 23, 2026
pondrejk added a commit that referenced this pull request Feb 23, 2026
adding blockedby to auth tests (#20837)

(cherry picked from commit 0f48d29)

Co-authored-by: Peter Ondrejka <pondrejk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.19.z CherryPick PR needs CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants