adjusted asserts for mcp user tests

[pondrejk]

Problem Statement

targeting an issue that isn't reproducible outside of our regular automation runs, therefore a bit mysterious. My hypothesis is that on the first run attempt the mcp client queries the mcp server before the connection with satellite is established using custom credentials.

Solution

Allow for a second try if the aforementioned issue happens

Related Issues

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the MCP user permission system tests to be more resilient to transient connection issues and to assert the exact error payload for denied resource access.

File-Level Changes

Change	Details	Files
Make the positive MCP user view permissions test resilient to a transient 'Max retries exceeded' error and tighten the assertion on the denied-resource response.	After the initial MCP client call to the Foreman API for the allowed resource, detect a specific transient failure pattern ('error' in result.data with 'Max retries exceeded') and immediately retry the same call once. Add a strict assertion that the denied resource response includes an 'Access denied' error message at result.data['response']['error']['message'], in addition to the existing message substring assertion.	tests/foreman/sys/test_mcp.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[pondrejk]

trigger: test-robottelo
pytest: tests/foreman/sys/test_mcp.py::test_positive_mcp_user_view_permissions

[sourcery-ai]

Hey - I've left some high level feedback:

• The retry logic based on checking for 'Max retries exceeded' in result.data['error'] is brittle; consider encapsulating this in a small helper or using a more structured condition (e.g., error code/type) so other error messages don’t trigger an opaque second call.
• The new assertion on result.data['response']['error']['message'] assumes a specific nested response structure; consider using .get or adding an explicit assertion that response and error keys exist to avoid confusing KeyError/TypeError failures.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The retry logic based on checking for `'Max retries exceeded'` in `result.data['error']` is brittle; consider encapsulating this in a small helper or using a more structured condition (e.g., error code/type) so other error messages don’t trigger an opaque second call.
- The new assertion on `result.data['response']['error']['message']` assumes a specific nested response structure; consider using `.get` or adding an explicit assertion that `response` and `error` keys exist to avoid confusing `KeyError`/`TypeError` failures.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Satellite-QE]

PRT Result

Build Number: 14424
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/sys/test_mcp.py::test_positive_mcp_user_view_permissions --external-logging
Test Result : ================== 4 passed, 39 warnings in 851.92s (0:14:11) ==================