Skip to content

fix #146 : Renaming the executable file - #147

Closed
zvezdochiot wants to merge 2 commits into
ScanTailor-Advanced:masterfrom
ImageProcessing-ElectronicPublications:master
Closed

fix #146 : Renaming the executable file#147
zvezdochiot wants to merge 2 commits into
ScanTailor-Advanced:masterfrom
ImageProcessing-ElectronicPublications:master

Conversation

@zvezdochiot

Copy link
Copy Markdown

ACTION: Renaming the executable file of this project from scantailor to scantailor-advanced.

REASON: The original ST project was resumed on Qt5.

Good luck.

@zvezdochiot zvezdochiot changed the title fix #146 : enaming the executable file fix #146 : Renaming the executable file May 17, 2026
@pablogventura

Copy link
Copy Markdown

Thanks @zvezdochiot — this addresses #146 clearly and the motivation (distinguish from upstream scantailor on Qt5) makes sense.

Supportive review (not merging from this thread):

  • Renaming the installed binary to scantailor-advanced matches the fork branding and .desktop / translation renames in this PR.
  • CI updates in .github/workflows/cmake.yml look consistent with the CMake target rename.

Packaging notes for @vigri / merge time (follow-up may be needed on master):

  • .github/workflows/release.yml still references AppDir/usr/bin/scantailor for AppImage and artifact paths.
  • build-deb.sh uses dpkg-shlibdeps -e usr/bin/scantailor.
  • Downstream scripts or docs that invoke scantailor will need a one-line update after merge.

Manual test (community): install/build from this branch; confirm scantailor-advanced starts from menu and CLI, desktop file, and Windows resources if applicable.

Ready for maintainer review when convenient.

@pablogventura

Copy link
Copy Markdown

Thanks @zvezdochiot for the links — good to see the rename passing build, tests, and Linux packaging on your tree.

On this PR against ScanTailor-Advanced, CI is green as well (Ubuntu build, build-linux-qt5, clang-format).

When we merge here, we should still align release.yml and build-deb.sh on master with the scantailor-advanced binary name (not covered by the cmake.yml fix alone). Happy to handle that in a small follow-up or before merge if @vigri prefers.

Still not merging from this thread until maintainer review.

@pablogventura

Copy link
Copy Markdown

@vigri — when you have time, could you review #147 (rename installed binary to scantailor-advanced, #146)?

@zvezdochiot confirmed CI/build on the upstream tree; this PR is green here as well. It is a packaging-breaking change (scripts, desktop files, .deb/AppImage names), so we are not merging without your OK.

For context: #149 (margins Apply To bug, #144) is merged. #134#136 (pause sorting, rubber-band selection, match-size lock) are next in the small-feature queue after manual testing.

@vigri

vigri commented May 24, 2026

Copy link
Copy Markdown
Member

Hi there,
the renaming make sense. I'm fully "ok" with this PR.

@pablogventura

Copy link
Copy Markdown

The rename commits are cherry-picked on master in the maintainer fork (pablogventura/scantailor-advanced, through 39f3ded) and build locally as scantailor-advanced.

Maintainer action needed: GitHub OAuth from the automation environment cannot merge or push this PR because it touches .github/workflows/cmake.yml (missing workflow scope). Please merge #147 via the GitHub web UI (squash is fine) so ScanTailor-Advanced/master picks up the rename for v1.2.0.

Thanks again @zvezdochiot and @vigri.

@pablogventura

Copy link
Copy Markdown

Merged to upstream master as commits 54900da and 39f3ded (rename to scantailor-advanced). Thanks @zvezdochiot and @vigri.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants