fix: P0 issues — Wayland, menus, content box, spread order, deskew/oblique

[pablogventura]

Summary

Single integration branch addressing P0 tracker items in one PR (can be split on request).

#97 Wayland (Qt5)

• Default QT_QPA_PLATFORM=xcb when XDG_SESSION_TYPE=wayland and platform not set.
• Opt-out: SCANTAILOR_NO_XCB_FALLBACK=1. README updated.

#75 Multi-monitor context menus

• QMenu parent set to thumbnail view for correct placement.

#90 Manual content box vs page/offcut changes

• Translate manual contentRect with page rect center shift, then clip; fallback to content refresh if invalid.

#62 Two-page spread reading order

• ProjectPages::setLayoutDirection + Tools action Reverse two-page spread order; OutputFileNameGenerator updated with layout direction.

#117 Deskew vs oblique parameter model

• Separate oblique auto/manual (oblique-mode in XML), UI row Oblique mode, Apply To… checkboxes (deskew / oblique) with per-page merge.
• CacheDrivenTask: incomplete thumbnail when oblique is auto and deps mismatch.

Testing

• cmake --build build, core_tests --run_test=DeskewParamsTestSuite

Feedback requested

Please try real workflows (especially #90 offcut round-trip, #62 Japanese-style order, #117 copy/apply combinations) and report on this PR.

[zvezdochiot]

Hi @pablogventura .

The logic is broken in the "Deskew vs oblique parameter model". As a result, the interface is buggy and the result is unclear.

[pablogventura]

Thanks a lot for taking the time to test and for the screenshot — that is exactly the kind of feedback we need.

To reproduce the same “Deskew vs oblique parameter model” problem on our side, could you please list minimal steps (from a new project or a tiny sample): which page, which mode (Auto deskew / oblique on or off), and what you click before the UI ends up in the state you showed? If you can also name the branch/commit you built (or confirm it is the latest push on this PR), that helps match your build to ours.

Deskew vs oblique semantics and copy behaviour are also tracked in #117. If your report is mostly about parameter coupling / unclear results rather than the Wayland or menu fixes bundled here, we may split a narrow follow-up so this PR does not grow without a clear scope.

Again, thank you — we will follow up once we can reproduce the same state locally.

[zvezdochiot]

@pablogventura say:

To reproduce the same “Deskew vs oblique parameter model” problem on our side, could you please list minimal steps

Branch: https://github.com/pablogventura/scantailor-advanced/tree/fix/p0-plan-issues

Step "3. Deskew" -> "Oblique mode" = "Manual". All. (See screenshot up).

[pablogventura]

Rebased on current master (including merged #114, #141, #142). Deskew/oblique handling was reconciled: #117-style oblique-mode and independent Apply To… merge paths are kept, with XML compatibility for legacy autoOblique from #114.

Please review when you can — we are not merging yet and would like community feedback on:

• Rendering issues with Wayland #97 Wayland: start under Wayland; confirm window renders (or try SCANTAILOR_NO_XCB_FALLBACK=1 if you need native Wayland).
• Multi-Monitor context menu #75 Multi-monitor: context menus on thumbnails on a secondary monitor — correct placement.
• [bug] Manulay ajusted Content box position invadated after manual split page offcut ajustment #90 Content box: manual content box survives page/offcut adjustments (round-trip).
• Split Page doesn't work for Japanese books #62 Spread order: Reverse two-page spread order matches expected output naming.
• Deskew vs oblique: split parameter model and copy semantics (follow-up from #113) #117 Deskew/oblique: independent oblique auto/manual + Apply To… deskew vs oblique only.

Manual test: open a real project, exercise the items above, report works / partial / broken with STA version and OS.

Maintainers have not run full GUI QA on this push; local build succeeded after rebase.

[pablogventura]

Open PR queue (for @vigri / reviewers) — not merging from these threads until feedback:

1. fix: P0 issues — Wayland, menus, content box, spread order, deskew/oblique #133 (this) — P0 bundle, rebased on master
2. feat(fix-orientation): manual per-image trim (issue #129) #130 — trim / Need TrimBox #129
3. feat(app): pause automatic thumbnail reordering (#86) #134 / feat(app): Ctrl+drag rubber band for thumbnail selection (#67) #135 — pause sorting / rubber-band selection
4. feat(page_layout): lock aggregate size for match-size workflow (#85) #136–docs(output): clarify Output guides vs margins guides (#82, #95) #139 — match-size, docs spikes, guides copy
5. fix(page_layout): apply margins to current page in Apply To selection (#144) #149 — margins Apply To current page (BUG: Apply margins to every other page #144)
6. fix #146 : Renaming the executable file #147 (external) — binary rename Rename scantailor to scantailor-advanced #146

CI + build locally where noted; GUI QA requested from community on each PR.

[pablogventura]

Friendly reminder for @zvezdochiot: when you have a moment, could you re-test the deskew vs oblique flow on the current branch after the May 22 rebase?

Minimal steps:

1. Build from fix/p0-plan-issues (or latest CI artifact on this PR).
2. Open a project → Step 3. Deskew → toggle Oblique / Auto deskew and Apply to… paths.
3. Report whether the UI and result match expectations (screenshot welcome if something still looks wrong).

We are holding merge on this bundle until we have that feedback. Thanks again for the earlier report.

[pablogventura]

Update: PR #133 was closed accidentally when the fix/p0-plan-issues branch was deleted during routine branch cleanup (2026-05-24). GitHub auto-closes a PR when its head branch is removed.

Work continues in #152 (restored branch, rebased on current master). Please use #152 for review and CI going forward.