fix(deskew): auto-oblique default and handle layout (#145) - #153
Merged
pablogventura merged 2 commits intoMay 24, 2026
Merged
Conversation
…ailor-Advanced#145) Connect Automatic oblique correction to DefaultParams and pending auto-oblique on deskew reload. Default oblique mode to Manual in UI and DefaultParams XML when the attribute is absent. Align deskew ImageView grid, arcs, and handles to the same content area rect (respecting visible scroll bars) so oblique levers stay positioned in windowed mode. Document AppImage glibc requirement (Ubuntu 24.04+) in README.
This was referenced May 24, 2026
This was referenced May 24, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes deskew/oblique regression reported by @zvezdochiot on #145 after #152 merge:
Automatic oblique correctioncheckbox toDefaultParamsandSettings::pendingAutoObliqueso auto deskew respects the global default (off by default).UiData; stop pre-checking Oblique Auto in the panel.ImageViewgrid, crosshair, rotation/oblique arcs and handles to one content-area rect (scrollbar-aware) — fixes misaligned oblique levers in windowed mode.autoObliqueattribute now defaults to off (matches constructor).Fixes #145 (near-term). Related #117.
Test plan
ctest— 5/5 passed locally (55 core tests)Release note
Planned for v1.2.1 after re-test confirmation (not tagging in this PR).