Fix typo in RCCircuit benchmark #1441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed typo in benchmarks/ModelingToolkit/RCCircuit.jmd:88 where `deeref` was used instead of `daeref`, causing an undefined variable error. This fixes issue SciML#1034 where the RC circuit benchmarks were broken. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a typo in the RC Circuit benchmark that was causing it to fail with an undefined variable error.
Changes
benchmarks/ModelingToolkit/RCCircuit.jmd:88wheredeerefwas incorrectly used instead ofdaerefIssue
Fixes #1034
Testing
daerefto match the other references in the same functiondaeref = nothingand used consistently in lines 90 and 92cc @ChrisRackauckas
🤖 Generated with Claude Code