Fix spelling errors and update typos whitelist #1443
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix typo: "orginal" -> "original" in enright_pryce.jl:483 - Fix typo: "pallete" -> "palette" in nelson.jmd:187 - Add "nd", "ND", and "ned" to typos whitelist for legitimate uses in Non-Dimensional (ND) problem names and related variables These spelling errors were causing CI spell check failures. The whitelisted terms are intentional abbreviations used throughout the benchmark codebase for non-dimensional problems. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes actual spelling errors in the benchmarks and updates the typos whitelist to allow legitimate abbreviations.
Changes
Spelling Fixes
orginal→originalpallete→paletteTypos Whitelist Updates
Added the following legitimate terms to
.typos.toml:nd- Used in variable names for Non-Dimensional problems (e.g.,nd1sys,nd2prob)ND- Abbreviation for "Non-Dimensional" in problem names and constants (e.g.,ND_PROBLEMS)ned- Used in variable names throughout the codebaseContext
The CI spell checker was failing on:
This PR addresses both issues by:
Related PRs
This PR complements the existing benchmark fixes:
Testing
cc @ChrisRackauckas
🤖 Generated with Claude Code